Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AGL for sitting setPos #2745

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Use AGL for sitting setPos #2745

merged 1 commit into from
Oct 14, 2015

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Oct 14, 2015
@PabstMirror PabstMirror added this to the 3.4.0 milestone Oct 14, 2015
@jonpas
Copy link
Member

jonpas commented Oct 14, 2015

What's the actual difference? Are there problems with how it was? Is the new not slower (not like it matters, just personal interest)? Never mind, I am blind. Looks good. 👍

@PabstMirror
Copy link
Contributor Author

https://community.bistudio.com/wiki/Position
modelToWorld returns AGL (which is the same as ASLW over water)

So on the carrier on utes, it's something like [x,y,16.5]
Doing player setPos [x,y,16.5] on the carrier, sticks you 16 meters up in the air.

I'm not entirely sure what format setPos uses? biki says AGL but I dont think that's right.
This explicitly converts AGL into ASL and then uses the setPosASL.

@kymckay
Copy link
Member

kymckay commented Oct 14, 2015

I think setPos is a kind of AGL, but if there's a building or something at the position it might not necessarily detect it, hence ATL.

So yeah, using ASL/ATL for accuracy is generally a good idea 👍

@jonpas
Copy link
Member

jonpas commented Oct 14, 2015

Perfect. 😀

PabstMirror added a commit that referenced this pull request Oct 14, 2015
@PabstMirror PabstMirror merged commit cb65a67 into master Oct 14, 2015
@PabstMirror PabstMirror deleted the fixChairsOverWater branch October 14, 2015 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants