Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations - Add German #10589

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Translations - Add German #10589

merged 14 commits into from
Dec 23, 2024

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Dec 22, 2024

When merged this pull request will:

  • Add missing German translations
  • Improve German translation of frag
  • Shorten some setting names

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Discussion

  • Existing translation of electronic hearing protection is literal. Wouldn't "Aktiver Gehörschutz" be better?
  • I'm not quite sure what the context of "Draw Event Spheres" in frag is

@LinkIsGrim LinkIsGrim added the kind/translation Release Notes: **TRANSLATIONS:** label Dec 22, 2024
@Timi007 Timi007 marked this pull request as ready for review December 22, 2024 18:12
@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Dec 22, 2024
@LinkIsGrim LinkIsGrim enabled auto-merge (squash) December 23, 2024 00:13
@LinkIsGrim LinkIsGrim merged commit 889b568 into acemod:master Dec 23, 2024
2 of 3 checks passed
@Timi007 Timi007 deleted the translation branch December 23, 2024 14:28
mcdazed pushed a commit to mcdazed/ace that referenced this pull request Dec 27, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants