Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluxMixin: check if component is mounted when updating #36

Merged
merged 3 commits into from
Feb 18, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/addons/FluxMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,10 @@ export default function FluxMixin(...args) {
let initialStoreState = storeStateGetter(store);

let listener = () => {
let state = storeStateGetter(store);
this.setState(state);
if (this.isMounted()) {
let state = storeStateGetter(store);
this.setState(state);
}
};

store.addListener('change', listener);
Expand Down
27 changes: 27 additions & 0 deletions src/addons/__tests__/FluxMixin-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,33 @@ describe('FluxMixin', () => {
);
});

it('ignores change event after unmounted', () => {
let flux = new Flux();
flux.getActions('test').getSomething('foo');

let getterMap = {
test: store => ({ something: store.state.something })
};
let Component = React.createClass({
mixins: [FluxMixin(getterMap)],

render() {
return null;
}
});

let container = document.createElement('div');
let component = React.render(<Component flux={flux} />, container);
let listener = flux.getStore('test').listeners('change')[0];

React.unmountComponentAtNode(container);

flux.getActions('test').getSomething('bar');
listener();

expect(component.state.something).to.equal('foo');
});

it('uses #connectToStores() to get initial state', () => {
let flux = new Flux();

Expand Down