FluxMixin: check if component is mounted when updating #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! |
acdlite
added a commit
that referenced
this pull request
Feb 18, 2015
FluxMixin: check if component is mounted when updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure exactly how it happens, but I ran into this bug in a fairly complex application. Somehow the change events get run even after the component is unmounted by a parent component. I think it has to do with the parent and child both listening to the same change event, the parent change handler is invoked first which removes the child, then the child handler is invoked immediately after.
This fixes it in FluxMixin by checking if the component is mounted before updating the state.