Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new license Anti-Capitalist Software License #2362 #2364

Merged
merged 894 commits into from
Aug 25, 2021
Merged

Add new license Anti-Capitalist Software License #2362 #2364

merged 894 commits into from
Aug 25, 2021

Conversation

sritasngh
Copy link
Contributor

@sritasngh sritasngh commented Jan 12, 2021 •
edited by pombredanne
Loading

Signed-off-by: itssingh saritasingh.0425@gmail.com
Fixes #2362

Added new licenses ANTI-CAPITALIST SOFTWARE LICENSE v-1.0, v-1.1, v-1.2, v-1.3 and v-1.4

These added licenses are giving correct scan result.

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne
pombredanne requested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few nitpickings for your consideration before we can merge.

@sritasngh sritasngh force-pushed the anti-capitalist branch 2 times, most recently from cae78e2 to f691361 Compare March 2, 2021 13:32
@sritasngh sritasngh requested a review from pombredanne March 13, 2021 14:44
@pombredanne pombredanne changed the title Added new license Anti-Capitalist Software License #2362 Add new license Anti-Capitalist Software License #2362 Mar 29, 2021
pombredanne
pombredanne requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itssingh Thank you! Almost there too here!

See the "ignorables"-related test failures in https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=3262&view=logs&j=3c16b29b-eb82-5c7a-26ca-153f5e2ef8d4&t=525ae439-c19a-5d45-abf1-df81b3df2f93&l=43551 for your review.

@sritasngh
Copy link
Contributor Author

sritasngh commented Mar 30, 2021 •
edited
Loading

See the "ignorables"-related test failures

should I put url in notes: ?

pombredanne
pombredanne reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I put url in notes:

no, you just need to add ignorable_* fields for URLs and emails

@sritasngh sritasngh requested a review from pombredanne June 3, 2021 10:57
pombredanne
pombredanne requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please consider the few cleanups I suggested. Also feel free to squash all your commits in a single one.

@sritasngh
Copy link
Contributor Author

consider the few cleanups I suggested

I left these #2364 (comment) as trailing line return #2364 (comment) as you previously suggested. Removed now :)

@sritasngh sritasngh requested a review from pombredanne June 4, 2021 01:26
pombredanne and others added 14 commits June 16, 2021 15:32
@pombredanne
Bump commoncode
729d5d6 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge pull request aboutcode-org#2557 from nexB/bump-commoncode
ce169cf 
Bump commoncode
@abhi27-web @pombredanne
Merge pull request aboutcode-org#2375 from abhi27-web/patch-1
5c7208a 
Update CONTRIBUTING.rst

Authored-by: Abhigya Verma<abhigyaverma27@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge remote-tracking branch 'upstream/develop' into alpianon-patch-d…
16914ae 
…ocumentnamespace
@pombredanne
Add CHANGELOG entry for SPDX format update
451f883 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Streamline SPDX formatting code aboutcode-org#2344
219ac9f 
Format code. Refactor common code between RDF and TV.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Update SPDX test expectatations aboutcode-org#2344
6c7c024 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use correct pytest setting for markers
1029068 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Clarify function to extract data from wheel name
d621379 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge remote-tracking branch 'pip2pi/master' into improve-thirdparty-…
f93558e 
…utilities
@AyanSinhaMahapatra
Add rules to improve debian-slim license detection
035d643 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Regenerate tests after adding rules
9ae88d5 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@akugarg
Add is_unknown flag for license class
a451a9c 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg
Add is_unknown flag to data files of unknown licenses
e62be42 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
pombredanne and others added 3 commits August 6, 2021 15:37
@pombredanne
Merge pull request aboutcode-org#2548 from akugarg/add_new_flag
0dd52df 
Add new flag in License Data Model definition
@mapelpapel
Update Contributing: Development setup-instructions
575c182 
Some instructions were not (exactly) right, and some commands are now also highlighted properly.

Signed-off-by: Marcel Rettig <mapelpapel@gmail.com>
@pombredanne
Merge pull request aboutcode-org#2631 from mapelpapel/update-contribu…
b7d070f 
…ting

Update Contributing: Development setup-instructions

Signed-off-by: Marcel Rettig <mapelpapel@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@sritasngh
Copy link
Contributor Author

@pombredanne Should I add notes for all the rules?

akugarg and others added 22 commits August 10, 2021 23:29
@akugarg
return referenced_filenames for licenses matches
a705382 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg
Update test cases upto expectations
ef8b217 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@pombredanne
Merge pull request aboutcode-org#2632 from akugarg/update_api
daeb709 
Referenced_filenames should be returned by API function
@petergardfjall
adds MIT detection rule 1055
1bab112 
This provides a rule that matches MIT notices of form (note: indent for highlight):

  License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
@petergardfjall
apache-2.0_328.RULE: set minimum_coverage to 70
0632f33 
This avoids Apache-2.0 "overriding" mit_349.RULE in cases like

  ## License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
@sritasngh
Add emails and urls
75a744f 
Add emails and urls in converted_infos. Add holders, authors, emails and
urls information in html template.

Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com>
Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>
@sritasngh
Add test for sample HTML template and update changelog
b7e35b7 
Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com>

Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>
@pombredanne
Merge pull request aboutcode-org#2539 from itssingh/html_temp
41d2d5b 
Add emails and urls to HTML output
@pombredanne
Merge pull request aboutcode-org#2636 from petergardfjall/issue-2635
6bf2fd9 
Avoid misinterpreting MIT license notice as Apache-2.0, issue aboutcode-org#2635
@akugarg
Add new talis community license
50b4fcc 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg
Merge branch 'nexB:develop' into add_new_licenses
5ec3144
@akugarg
Update test cases upto expectations
d954e40 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg
Add final report for GSoC'21
b51e281 
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg
Merge pull request aboutcode-org#2648 from akugarg/final_report
3be07db 
Add final report for GSoC'21
@pombredanne
Merge branch 'develop' into 2110-dart-pubspec
0a4972e
@yns88
Add "--no-check-version" CLI option to scancode
23c8ef0 
This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely.

Signed-off-by: Yunus Rahbar <yrahbar@fb.com>
@pombredanne
Merge pull request aboutcode-org#2662 from yns88/no-check-version
f7b3a93 
Add "--no-check-version" CLI option to scancode
@pombredanne
Merge pull request aboutcode-org#2628 from nexB/2110-dart-pubspec
1cfe28f 
Align tests for pubspec with latest code
@pombredanne
Merge pull request aboutcode-org#2625 from akugarg/add_new_licenses
884f829 
Add new licenses
@pombredanne
Merge remote-tracking branch 'itssingh/anti-capitalist' into develop
e18f389
@pombredanne
Remove trailing tab from license data files
c79c0ec 
Somehow a tab had squeezed in

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Do not use encoding with json.loads
2da1247 
This is no longer supported in newest Python versions.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

FYI I merged the latest develop and fixed the tests, then pushed back to your branch

pombredanne
pombredanne approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging now at last. Thanks!

@pombredanne pombredanne merged commit 3a82423 into aboutcode-org:develop Aug 25, 2021
@sritasngh sritasngh deleted the anti-capitalist branch October 9, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect License detected for Anti-Capitalist Software License