Add new licenses #2625
Merged
Add new licenses #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
bff345a to
fe08a5f
Compare
pombredanne
reviewed
Aug 9, 2021
22b416d to
19da689
Compare
|
@pombredanne the failing check mentioned here ,is it related to something that I have added? |
pombredanne
requested changes
Aug 15, 2021
| key: dpl | ||
| short_name: DPL | ||
| name: THE DEFENSIVE PATENT LICENSE v1.1 | ||
| owner: Unspecified |
19da689 to
11f9e6e
Compare
Yes and no... I think we could remove entirely that test failing tests (tests/licensedcode/test_query.py::TestQueryWithFullIndex::test_Query_tokens_by_line_behaves_the_same_on_various_python ) and its data files as this only served a purpose when we were porting from Python 2 to Python 3. Nowadays it only ever fails when we have some significant new words added in new licenses... and that's useless since we are all on Python 3 |
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
c69214f to
50b4fcc
Compare
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
0fc34a0 to
d954e40
Compare
pombredanne
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR new licenses
Tasks
Run tests locally to check for errors.