Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix globals and other NAMESPACE issues #47

Closed
Ryo-N7 opened this issue May 18, 2022 · 4 comments
Closed

fix globals and other NAMESPACE issues #47

Ryo-N7 opened this issue May 18, 2022 · 4 comments
Assignees

Comments

@Ryo-N7
Copy link
Collaborator

Ryo-N7 commented May 18, 2022

na.omit is from {stats} and not base... used in plot_passnet()... tbh could just filter NAs in a different way using the imports we already have

otherwise the usual global vars shenanigans that i'll need to add into globals.R

@Ryo-N7 Ryo-N7 self-assigned this May 18, 2022
@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 18, 2022

but more importantly need to change all the @import to be more specific via importFrom but that might be its own issue to tackle separately

@harshkrishna17
Copy link
Collaborator

@import useful can be changed to @importFrom useful shift.column

@harshkrishna17
Copy link
Collaborator

The above change is in plot_passnet()

Ryo-N7 added a commit that referenced this issue May 18, 2022
- add global vars
- fix namespace issues

references #47
@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 19, 2022

after discussion with Harsh, we can just throw the shift.column() function over into utils.R and modify it a bit better for our own use instead of importing the package just for that single function (which is written all in base anyways)

Ryo-N7 added a commit that referenced this issue May 19, 2022
…kage

- remove useful from imports and namespace
- remove Rcpp and RcppRoll from imports (unused)

references #47
Ryo-N7 added a commit that referenced this issue Jun 20, 2022
@Ryo-N7 Ryo-N7 closed this as completed in 8f555d8 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants