Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible new dependencies for version 0.2.0 #26

Closed
harshkrishna17 opened this issue Apr 16, 2022 · 3 comments
Closed

possible new dependencies for version 0.2.0 #26

harshkrishna17 opened this issue Apr 16, 2022 · 3 comments

Comments

@harshkrishna17
Copy link
Collaborator

harshkrishna17 commented Apr 16, 2022

There are a few packages that are required for the new functions in version 0.2.0 to be added to the dependencies list. They are :-

  1. purrr {plot_convexhull}. Mapping a function to a list. Functions required are map() and reduce().
  2. useful {plot_passnet}. Function required is shift.column().
  3. gridExtra {plot_passnet}. Function required is tableGrob().

There are a few more packages that can be removed :-

  1. Rcpp & RcppRoll. Since we already have TTR to calculate the rolling average, we dont require either package.
  2. wesanderson. This is an option as we already have a colour scale package in viridis. Or of course we can just create a manual colour scale where the colours are an option to the user.
@Ryo-N7 Ryo-N7 changed the title Dependencies for version 0.2.0 possible new dependencies for version 0.2.0 Apr 16, 2022
@Ryo-N7
Copy link
Collaborator

Ryo-N7 commented Apr 16, 2022

@Ryo-N7 Ryo-N7 mentioned this issue Apr 17, 2022
8 tasks
@harshkrishna17
Copy link
Collaborator Author

Since the removal of Rcpp and RcppRoll from imports has been shifted to issue #47 (fix globals and other NAMESPACE issues), should this issue be closed?

@Ryo-N7
Copy link
Collaborator

Ryo-N7 commented May 19, 2022

yeah i mean this should've just been a note or something in the chat rather than an issue by itself since all of the changes were going to be handled in other issues from the start anyway

@Ryo-N7 Ryo-N7 closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants