Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #44

Closed
Ryo-N7 opened this issue May 16, 2022 · 5 comments
Closed

Improve tests #44

Ryo-N7 opened this issue May 16, 2022 · 5 comments
Assignees
@Ryo-N7 @abhiamishra @harshkrishna17
Milestone
Finish release of...

Comments

@Ryo-N7
Copy link
Collaborator

Ryo-N7 commented May 16, 2022

Lots of them right now are very barebones is this a ggplot2 object type tests...

Look at codecov: https://codecov.io/gh/abhiamishra/ggshakeR/tree/767fd3a877154aab030afa0c49be599596d42ce0/R

and start doing more to fill out tests for ALL configurations of arguments

as well as doing more tests to check for the error messages that we've started adding into the function for 'clear and obvious' errors that users might make like forgetting certain cols or an entire df
@Ryo-N7 Ryo-N7 self-assigned this May 16, 2022
@abhiamishra
Copy link
Owner

Think the easiest way to go about this is to assign tests for functions we've written.

I'll start with these five:

  • calculate_xt
  • calculate_threat
  • plot_voronoi
  • plot_shot
  • plot_passflow

@harshkrishna17
Copy link
Collaborator

I'll take

  • plot_passnet
  • plot_convexhull
  • plot_pizza
  • plot_trendline
  • plot_timeline

@harshkrishna17
Copy link
Collaborator

#77 StatsBomb dataset added to testdata folder which can now be used for tests

@harshkrishna17
Copy link
Collaborator

harshkrishna17 commented Jun 23, 2022 •
edited by abhiamishra
Loading

Functions to be tested:

  • plot_convexhull()
  • plot_heatmap()
  • plot_pass()
  • plot_passflow()
  • plot_passnet()
  • plot_shot()
  • plot_sonar()
  • plot_voronoi()
  • plot_pizza()
  • plot_scatter()
  • plot_trendline()
  • plot_timeline()
  • calculate_epv()
  • calculate_threat()

@abhiamishra abhiamishra linked a pull request Jun 23, 2022 that will close this issue
Fixing test issues for calculate_threat #81
Merged
@abhiamishra abhiamishra removed a link to a pull request Jun 23, 2022
Fixing test issues for calculate_threat #81
Merged
harshkrishna17 added a commit that referenced this issue Jun 26, 2022
@harshkrishna17
improve tests #44 (#84)
0ff6302 
* improve tests by increasing coverage  

* more fixes suggested by lintr comments
abhiamishra added a commit that referenced this issue Jul 10, 2022
@abhiamishra
EPV testing (#90)
d267183 
Duplicated testing for xT threat function on EPV function.

Included 4 tests:

- Opta type
- Statsbomb type
- Empty dataframe
- Dataframe with missing columns

Works on Issue #44
abhiamishra added a commit that referenced this issue Jul 10, 2022
@abhiamishra
Fixing tests for plot_shot (#91)
d4c18fc 
Went through all the arguments and did testing on whether those arguments resulted in a ggplot plot object. 

Works on Issue #44
abhiamishra added a commit that referenced this issue Jul 11, 2022
@abhiamishra
Fixing passflow tests (#92)
1d93996 
Fixed pass flow tests by going through all the arguments in the function.

Added SampleSBData to the website as well

Works on Issue #44
This was referenced Jul 11, 2022
Merged
Closed
abhiamishra added a commit that referenced this issue Jul 12, 2022
@abhiamishra
Fixing tests for plot_scatter and checking EPV/xT calc (#94)
5856274 
Fixed plot_scatter tests by going through all the arguments.

Changes were made to calculate_epv() to fix EPV calculations

Closes Issue #44 and closes Issue #58
@abhiamishra
Copy link
Owner

All tests are done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ryo-N7 Ryo-N7

@abhiamishra abhiamishra

@harshkrishna17 harshkrishna17

Labels
None yet
Projects
None yet
Milestone
Finish release of 0.2.0 ggshakeR
Development

No branches or pull requests
3 participants
@Ryo-N7 @abhiamishra @harshkrishna17