Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPV testing #90

Merged
merged 1 commit into from
Jul 10, 2022
Merged

EPV testing #90

merged 1 commit into from
Jul 10, 2022

Conversation

abhiamishra
Copy link
Owner

@abhiamishra abhiamishra commented Jul 10, 2022 •
edited
Loading

Checklist

Before creating the Pull-Request, I...

  • Ran devtools::document() and Install and Restart.
  • Ran devtools::check() (GHA will do this but doesn't hurt to check yourself).
  • (If applicable) Checked changes made to website with pkgdown::build_site().
  • Wrote commit message(s) throughout the time spent working on this branch with clear details of changes made.
  • (If applicable) Created new tests for new functions or changes made to existing functions (Check codecov).

After all of the Github Actions Checks have finished, I...

  • Checked lintr issues by going to the latest commit or the Checks tab.
  • Used Squash & Merge option.
  • Wrote in detail of all the changes made in the various commits on this branch.
  • Added a keyword like closes #56, fixes #123 at the end of the message.
  • Merged the Pull-Request.
  • Deleted the branch.

@abhiamishra
Copy link
Owner Author

Duplicated testing for xT threat function on EPV function.

Included 4 tests:

  • Opta type
  • Statsbomb type
  • Empty dataframe
  • Dataframe with missing columns

@abhiamishra abhiamishra merged commit d267183 into main Jul 10, 2022
@abhiamishra abhiamishra deleted the issue#44-EPVTesting branch July 10, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhiamishra