Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Require full sync to reach 100% #4474

Closed
wants to merge 3 commits into from
Closed

fix(ci): Require full sync to reach 100% #4474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23d1a3e
Stop full sync at 97%, but send transactions at 100%
teor2345 May 25, 2022
4d72254
Revert "Stop full sync at 97%, but send transactions at 100%"
teor2345 May 25, 2022
d3c4889
Revert "fix(ci): Temporarily finish full sync at 99% (#4457)"
teor2345 May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/continous-integration-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ jobs:
needs_zebra_state: false
saves_to_disk: true
disk_suffix: tip
height_grep_text: 'estimated progress to chain tip sync_percent=99.* current_height=Height'
height_grep_text: 'finished initial sync to chain tip, using gossiped blocks sync_percent=100.* current_height=Height'

# Test that Zebra can answer a synthetic RPC call, using a cached Zebra tip state
#
Expand Down
5 changes: 1 addition & 4 deletions zebrad/tests/common/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ pub const STOP_AT_HEIGHT_REGEX: &str = "stopping at configured height";
/// - we have synced all known checkpoints,
/// - the syncer has stopped downloading lots of blocks, and
/// - we are regularly downloading some blocks via the syncer or block gossip.
///
/// Temporary workaround for slow syncs - stop at 99.5%.
/// TODO: revert this change (#4456)
pub const SYNC_FINISHED_REGEX: &str = "estimated progress to chain tip sync_percent=99";
pub const SYNC_FINISHED_REGEX: &str = "finished initial sync to chain tip, using gossiped blocks";

/// The maximum amount of time Zebra should take to reload after shutting down.
///
Expand Down