Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Require full sync to reach 100% #4474

Closed
wants to merge 3 commits into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 24, 2022

Motivation

PRs #4457 and #4483 were a temporary fix, we want to restore full test coverage after we find another way to speed up the sync.

Scheduling

Depends-On: #4456

Solution

Reverts #4457
Reverts #4483

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ C-testing Category: These are tests lightwalletd any work associated with lightwalletd labels May 24, 2022
@teor2345 teor2345 self-assigned this May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #4474 (d3c4889) into main (49406f3) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4474      +/-   ##
==========================================
- Coverage   78.92%   78.79%   -0.14%     
==========================================
  Files         304      304              
  Lines       37285    37285              
==========================================
- Hits        29428    29379      -49     
- Misses       7857     7906      +49     

dconnolly
dconnolly previously approved these changes May 24, 2022
@teor2345
Copy link
Contributor Author

We'll re-do this change as part of ticket #4661.

@teor2345 teor2345 closed this Jun 21, 2022
@teor2345 teor2345 deleted the revert-4457-full-sync-995 branch September 5, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants