fix(zebrad/test): use the correct stop condition for the cached state tests #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
- Coverage 79.98% 79.95% -0.04%
==========================================
Files 288 288
Lines 32755 32755
==========================================
- Hits 26200 26190 -10
- Misses 6555 6565 +10 |
dconnolly
approved these changes
Mar 2, 2022
45 tasks
45 tasks
45 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In bug #3664, the cache state tests always fail. We need to fix this failure before we can fix the CI job so it detects failures.
Solution
Review
This fix is more important than routine work, because the bug hides other CI failures.
This is a minor fix that anyone can review, but I'll pick @jvff.
Reviewer Checklist
Follow Up Work
@gustavovalverde can do the rest of #3664 once this PR merges.