sync_past_mandatory_checkpoint_mainnet fails, but CI job succeeds

[teor2345]

Motivation

The sync_past_mandatory_checkpoint_mainnet test is currently failing:

0: stdout of command did not contain any matches for the given regex

Match Regex:
"stopping at configured height"

https://github.com/ZcashFoundation/zebra/runs/5329552803?check_suite_focus=true#step:10:199

But the CI job succeeds anyway.

Tasks

• fix the test harness so the test passes
  • done in fix(zebrad/test): use the correct stop condition for the cached state tests #3688
• make the CI job fail when the test fails
• check other CI jobs for the same bug

Related Work

[ftm1000]

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @gustavovalverde @jvff @oxarbitrage @teor2345 @upbqdn

[gustavovalverde]

The issue here is that I'm basically just reading the logs, and there's not an exit code when the logs stop capturing data. So I'll just find a way to capture the status of the container after the logs finished. This might require an extra step, but it will ensure an exit code is captured after we have no output from the logs

[teor2345]

The issue here is that I'm basically just reading the logs, and there's not an exit code when the logs stop capturing data. So I'll just find a way to capture the status of the container after the logs finished. This might require an extra step, but it will ensure an exit code is captured after we have no output from the logs

The test harness is the same as other tests, and produces the same exit statuses:

zebra/zebrad/tests/acceptance.rs

Lines 1365 to 1369 in 675fa36

	fn sync_past_mandatory_checkpoint_mainnet() {
	zebra_test::init();
	let network = Mainnet;
	sync_past_mandatory_checkpoint(network).unwrap();
	}

Can we do the same checks for the test exit status?

[teor2345]

Does the full sync test also have the same exit status issue?
It uses a similar test harness, but it produces a lot more logs.

(We know the lightwalletd integration test doesn't have the same issue, because it is failing right now 🤣)