Implement Sapling serialization in Transaction V5 #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure that serialized bytes match if structs match.
And split out sapling ShieldedData serialization.
2 tasks
This was referenced Apr 16, 2021
oxarbitrage
approved these changes
Apr 16, 2021
Comment on lines
+102
to
+108
| let (spend_prefixes, spend_proofs_sigs): (Vec<_>, Vec<_>) = self | ||
| .spends() | ||
| .cloned() | ||
| .map(sapling::Spend::<SharedAnchor>::into_v5_parts) | ||
| .map(|(prefix, proof, sig)| (prefix, (proof, sig))) | ||
| .unzip(); | ||
| let (spend_proofs, spend_sigs) = spend_proofs_sigs.into_iter().unzip(); |
Comment on lines
+182
to
+187
| let mut spends: Vec<_> = spend_prefixes | ||
| .into_iter() | ||
| .zip(spend_proofs.into_iter()) | ||
| .zip(spend_sigs.into_iter()) | ||
| .map(|((prefix, proof), sig)| Spend::<SharedAnchor>::from_v5_parts(prefix, proof, sig)) | ||
| .collect(); |
| zebra_test::init(); | ||
|
|
||
| // we need at least one output to delete all the spends | ||
| prop_assume!(shielded_v4.outputs().count() > 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction V5 is a required change in NU5.
Solution
The code in this pull request has:
Review
@teor2345 can review @oxarbitrage's commits.
@oxarbitrage can review @teor2345's commits.
Related Issues
Part of #1829
Rebased from oxarbitrage#90
Follow Up Work
Redesign Sapling data model for V5 shared anchor and spends #2021
TODO - make tickets:
fake_v5_round_triptest fails on blocks, but not transactions (re-test on Redesign Sapling data model for V5 shared anchor and spends #2021 first)Orchard in V5 #1979