Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more proptest strategies for sapling shielded data #2024

Closed
oxarbitrage opened this issue Apr 16, 2021 · 1 comment
Closed

Add more proptest strategies for sapling shielded data #2024

oxarbitrage opened this issue Apr 16, 2021 · 1 comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup

Comments

@oxarbitrage
Copy link
Contributor

In #2020 we added support for sapling shielded data in V5 transactions and we added a good amount of test coverage for the new feature.

In the file zebra-chain/src/sapling/tests/prop.rs we modify the generated shielded data in several tests instead of having more strategies. There are TODO comments at each spot we are doing this:

// TODO: modify the strategy, rather than the shielded data

The solution is to generate different strategies that have what we need, for example instead of just shielded_v4 and shielded_v5 strategies we can have shielded_v4_no_spends, shielded_v4_no_outputs, shielded_v4_full, shielded_v4_empty, etc.

This is currently low priority.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Optional labels Apr 17, 2021
@mpguerra mpguerra added the S-needs-triage Status: A bug report needs triage label May 25, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 4, 2021
@mpguerra mpguerra added P-Low and removed P-Low labels Jun 14, 2021
@oxarbitrage
Copy link
Contributor Author

oxarbitrage commented Mar 18, 2022

Not needed right now and there are TODO comments in the code. We can always reopen or open a new issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Development

No branches or pull requests

3 participants