You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #2020 we added support for sapling shielded data in V5 transactions and we added a good amount of test coverage for the new feature.
In the file zebra-chain/src/sapling/tests/prop.rs we modify the generated shielded data in several tests instead of having more strategies. There are TODO comments at each spot we are doing this:
// TODO: modify the strategy, rather than the shielded data
The solution is to generate different strategies that have what we need, for example instead of just shielded_v4 and shielded_v5 strategies we can have shielded_v4_no_spends, shielded_v4_no_outputs, shielded_v4_full, shielded_v4_empty, etc.
This is currently low priority.
The text was updated successfully, but these errors were encountered:
In #2020 we added support for sapling shielded data in V5 transactions and we added a good amount of test coverage for the new feature.
In the file
zebra-chain/src/sapling/tests/prop.rs
we modify the generated shielded data in several tests instead of having more strategies. There areTODO
comments at each spot we are doing this:// TODO: modify the strategy, rather than the shielded data
The solution is to generate different strategies that have what we need, for example instead of just
shielded_v4
andshielded_v5
strategies we can haveshielded_v4_no_spends
,shielded_v4_no_outputs
,shielded_v4_full
,shielded_v4_empty
, etc.This is currently low priority.
The text was updated successfully, but these errors were encountered: