Skip to content

Commit

Permalink
Remove incomplete and currently unnecessary code
Browse files Browse the repository at this point in the history
The current implementation works, the commented out code was just a
previous improvement idea, which is now tracked by issue #2473.
  • Loading branch information
jvff committed Jul 9, 2021
1 parent 080feaf commit e37e17e
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions zebra-consensus/src/transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,30 +43,17 @@ mod tests;
pub struct Verifier<ZS> {
network: Network,
script_verifier: script::Verifier<ZS>,
// spend_verifier: groth16::Verifier,
// output_verifier: groth16::Verifier,
// joinsplit_verifier: groth16::Verifier,
}

impl<ZS> Verifier<ZS>
where
ZS: Service<zs::Request, Response = zs::Response, Error = BoxError> + Send + Clone + 'static,
ZS::Future: Send + 'static,
{
// XXX: how should this struct be constructed?
pub fn new(network: Network, script_verifier: script::Verifier<ZS>) -> Self {
// There was a discussion that instantiating the verifiers here or externally and passed as
// constructor parameters might help with testing:
// https://github.com/ZcashFoundation/zebra/issues/2390#issuecomment-870159482
//
// let (spend_verifier, output_verifier, joinsplit_verifier) = todo!();

Self {
network,
script_verifier,
// spend_verifier,
// output_verifier,
// joinsplit_verifier,
}
}
}
Expand Down

0 comments on commit e37e17e

Please sign in to comment.