Consider refactoring the verifiers in transaction::Verifier
#2473
Labels
Comments
jvff
added a commit
to jvff/zebra
that referenced
this issue
Jul 9, 2021
The current implementation works, the commented out code was just a previous improvement idea, which is now tracked by issue ZcashFoundation#2473.
3 tasks
jvff
added a commit
to jvff/zebra
that referenced
this issue
Jul 9, 2021
The current implementation works, the commented out code was just a previous improvement idea, which is now tracked by issue ZcashFoundation#2473.
jvff
added a commit
to jvff/zebra
that referenced
this issue
Jul 9, 2021
The current implementation works, the commented out code was just a previous improvement idea, which is now tracked by issue ZcashFoundation#2473.
teor2345
pushed a commit
that referenced
this issue
Jul 9, 2021
* Add panic message to `unimplemented!` So that it is clear why the panic happened upon initial inspection. Also include a reference to the mempool epic, so that it's easier to find the issue that tracks the implementation of the missing code. * Add panic message that references a tracking issue Make it easy to find the relevant issue if the panic occurs. * Remove incomplete and currently unnecessary code The current implementation works, the commented out code was just a previous improvement idea, which is now tracked by issue #2473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
The
transaction::Verifiercurrently uses a shared global instance of each cryptographic verifier. If there's only one transaction verifier instance, having singleton cryptographic verifiers isn't necessary, and also makes testing slightly more complicated (see #2390).Related Work
This idea was initially briefly discussed here:
#2390 (comment)
The text was updated successfully, but these errors were encountered: