Skip to content

Commit

Permalink
fix: Fix a null bit set in left index lookup join (facebookincubator#…
Browse files Browse the repository at this point in the history
…12226)

Summary:
Pull Request resolved: facebookincubator#12226

Fix null bit setting in left index lookup join as the bits fill take [start, end) but not {start, length}.
Found in Meta internal tests.

Reviewed By: zacw7

Differential Revision: D68941198

fbshipit-source-id: 5f124394f6c3b0a9e370ca413ebdc58a509d67c3
  • Loading branch information
xiaoxmeng authored and facebook-github-bot committed Jan 31, 2025
1 parent 832583d commit b127d51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/exec/IndexLookupJoin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ RowVectorPtr IndexLookupJoin::produceOutputForLeftJoin() {
bits::fillBits(
rawLookupOutputNulls_,
numOutputRows,
numOutputMissedInputRows,
numOutputRows + numOutputMissedInputRows,
bits::kNull);
for (auto i = 0; i < numOutputMissedInputRows; ++i) {
rawProbeOutputRowIndices_[numOutputRows++] = ++lastProcessedInputRow;
Expand Down

0 comments on commit b127d51

Please sign in to comment.