fix: Fix a null bit set in left index lookup join #12226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68941198 |
✅ Deploy Preview for meta-velox canceled.
|
zacw7
approved these changes
Jan 31, 2025
velox/exec/IndexLookupJoin.cpp
Outdated
| @@ -453,7 +453,7 @@ RowVectorPtr IndexLookupJoin::produceOutputForLeftJoin() { | |||
| bits::fillBits( | |||
| rawLookupOutputNulls_, | |||
| numOutputRows, | |||
| numOutputMissedInputRows, | |||
| nnumOutputRows + numOutputMissedInputRows, | |||
There was a problem hiding this comment.
typo?
Suggested change
| nnumOutputRows + numOutputMissedInputRows, | |
| numOutputRows + numOutputMissedInputRows, |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jan 31, 2025
…12226) Summary: Fix null bit setting in left index lookup join as the bits fill take [start, end) but not {start, length}. Found in Meta internal tests. Reviewed By: zacw7 Differential Revision: D68941198
b796182 to
cf359a3
Compare
…12226) Summary: Fix null bit setting in left index lookup join as the bits fill take [start, end) but not {start, length}. Found in Meta internal tests. Reviewed By: zacw7 Differential Revision: D68941198
cf359a3 to
4aaae1b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68941198 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68941198 |
|
This pull request has been merged in b127d51. |
ArnavBalyan
pushed a commit
to ArnavBalyan/velox
that referenced
this pull request
Jan 31, 2025
…12226) Summary: Pull Request resolved: facebookincubator#12226 Fix null bit setting in left index lookup join as the bits fill take [start, end) but not {start, length}. Found in Meta internal tests. Reviewed By: zacw7 Differential Revision: D68941198 fbshipit-source-id: 5f124394f6c3b0a9e370ca413ebdc58a509d67c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix null bit setting in left index lookup join as the bits fill take [start, end) but not {start, length}.
Found in Meta internal tests.
Differential Revision: D68941198