Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Feature/diagnostics system console #115

Merged
merged 12 commits into from
Dec 30, 2019

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Dec 22, 2019

Overview

Please use XRTK/com.xrtk.core#422 for discussion and overview.

@StephenHodgson
Copy link
Contributor

Could you do me a favor and update the speech commands profile with actions set to None or something that makes more sense please? I noticed they were kinda strange the other day.

@FejZa
Copy link
Contributor Author

FejZa commented Dec 23, 2019

I did. Also set the KeyCodes to none, because they currently also don't make any sense. Those default speech commands need a revision I think because if they are there they should also function by default.

StephenHodgson and others added 2 commits December 23, 2019 17:03
* updated the diagnostics handlers a bit

* updated the prefab and renamed visualizers to handlers

* updated prefab and updated events

* updated anchors

* update console message text in pooled array

* added console text color options

* removed redundant disable/enable

* Fixed the scaling a bit more and flipped the pin sprite

replaced radial solver with orbital one for better control

* tweaked visuals a bit
@FejZa
Copy link
Contributor Author

FejZa commented Dec 29, 2019

@StephenHodgson the SDK PR validation keeps failing in the license activation step. Any ideas what's going on?

@StephenHodgson
Copy link
Contributor

It's bc there's a breaking change in the core that needs a release before it'll pass. I don't mind ignoring it for now.

@StephenHodgson
Copy link
Contributor

See XRTK/com.xrtk.core#428

Once that gets merged and a new release then the compiler errors will go away.

It's not an issue with licensing

@FejZa
Copy link
Contributor Author

FejZa commented Dec 29, 2019

alright. I just checked in DevOps and the step that failed was about license activation. But sounds like you got the plan 🙂

@StephenHodgson
Copy link
Contributor

That was the step it failed on but the logs say it was a compiler error.

Likely from the breaking changes in the PR I specified above.

@StephenHodgson StephenHodgson merged commit 616ad69 into development Dec 30, 2019
@StephenHodgson StephenHodgson deleted the feature/diagnostics-system-console branch December 30, 2019 16:58
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 30, 2019
* Recreate default profiles for diagnostics

* Set test prefab for visualization

* Update default diagnostics profile

* Add TMP assembly reference

* Implement default visualizers

* Update default profile

* Update colors used in frame visualization and memoery visualization to match

* Clear speech commands actions and key codes

* initialized some fields

* Change requests/diagnostics system update (#116)

* updated the diagnostics handlers a bit

* updated the prefab and renamed visualizers to handlers

* updated prefab and updated events

* updated anchors

* update console message text in pooled array

* added console text color options

* removed redundant disable/enable

* Fixed the scaling a bit more and flipped the pin sprite

replaced radial solver with orbital one for better control

* tweaked visuals a bit

* updated sdk package information

* updated upm packages

Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants