This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
broke out the changes from the diagnostics PR #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
approved these changes
Dec 29, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 30, 2019
* broke out the changes from the diagnostics PR * updated xrtk-core package to 0.1.28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Broke out a few of the braking changes from the Diagnostics PR.
Mainly this is just a cleanup pass.
Target of the change:
Is this enhancement for:
Changes:
Some of the biggest changes:
MixedRealityToolkitservice registration to no longer check if a profile is null, as these services require the profiles they're checking. (in fact theIsServiceEnabledflag is typically bundled with this profile null check anyway.)Breaking Changes:
Are there any breaking changes included in this change that would prevent or cause issue for existing projects.
IMixedRealityBaseEventSystem.EventListenersis now a readonly type:IReadonlyList<GameObject>