This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Change requests/cleanup definitions #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed allocators each frame when lerping between two poses misc formatting
…initions # Conflicts: # XRTK-Core/Packages/com.xrtk.core/Definitions/Controllers/Simulation/Hands/SimulatedHandControllerDataProviderProfile.cs # XRTK-Core/Packages/com.xrtk.core/Definitions/InputSystem/MixedRealityHandTrackingProfile.cs
This was referenced Apr 4, 2020
FejZa
approved these changes
Apr 4, 2020
| /// Timestamp of hand data, as FileTime, e.g. DateTime.UtcNow.ToFileTime(). | ||
| /// Gets the total count of joints the hand data supports. | ||
| /// </summary> | ||
| public static readonly int JointCount = Enum.GetNames(typeof(TrackedHandJoint)).Length; |
There was a problem hiding this comment.
I thought it made more sense here than in the controller class.
StephenHodgson
added a commit
that referenced
this pull request
Apr 7, 2020
* Update profile platform utility * Add and implement TryGetBounds(...) for hand controllers * Update submodule * Move hand visualizers to SDK * Remove mesh and joint visualizer setting * Update SDK submodule * Resolve merge issue * Update inspector namespace * Fix simulation created asset path and name * Fix UpdateController() not in basecontroleller interface * Base hand data provider cleanup * Remove all occurences of default hand controller * Moving state update to hand controller * Pipe hand data update though input system * Fix namespaces and assign asset icons * Remove obsolete hand specific visualization profile * Update submodules * Remove IMixedRealityHandControllerDataProvider since obsolete * Separate simulation and hands * Remove SimulationInput (using MixedRealityPose instead) * Add simulated controller type setting * Update SDK checkout * Cleanup simulated dp * Undo newline file changes * Update submoduules * Remove profile property from data provider and expose settings as properties * Merge SimulatedHandControllerState into SimulatedHandController * Move constructors to top * Rename HandUtils to HandUtilities * Remove HandRay class (returning in separate PR) * Cleanup utils and make extensions * Some more extnsion conversions * Remove not needed setter * Remove dead event definition * Remove setters in hand data snapshot * Add setter to hand data mesh property * Remove cached camera rerefence * Update SDK * Add hand mesh data constructors * Update Oculus submodule * Revert some meta files not related to hands changes * Revert not related change * Remove simulated controller controls from profile * Update interactions in base * Use interaction mapping for movement * Reset editor window options * remove hand joitn pose dictionary * Update SDK checkout * Pull update controller * Update submodules * Remove redundant joint count definition * Fix broken JointCount references * Minor BaseHandController cleanup * Fix copy paste error in windows api checker * Update submodules * Fix missing UpdateController definition issue * Fix controller list management * Update submodules * Update SDK checkout * Update SDK checkout * Update SDK * Define agnostic hand controller update * Fix namespaces and create mr hand controller mapping profile * Fix texture path for hand mapping profile * Update SDK checkout * Update WMR checkout * Update submodules * Update submodules * Update submodules * Upate simulated hand controller implementation to new interface * Make joint poses private * Add comment for simulation specifc update * Update submodules * Update sdk checkout * Update submodules * Move interaction updates to base hand * Remove default interactions defintions * Cleanup using * Update SDK checkout * Remove hand triangles shader * Update submodules * Update SDK checkout * Implement Gizmo utlity to draw wire capsule * Update SDK * Implement GetOrAddComponent extension * Implement bounds calculation for each TrackedHandBounds type * Update SDK checkout * Update SDK * Introduce shared hand profile configuraiton * Introduce base hand controller data provide to consume shared profile * Update simulation to make use of new shared hand data provider settings * Add label to Simulation specific in inspector * Update submodules * Update Oculus checkout * Introduce HandMeshingEnabled profile setting * Raise input source events in base hand controller * Update SDK * Delete now redundant GizmoUtility * Introduce "Hand Tracking System Profile" * Implement hand ray configuration * Update SDK * Update SDK * Update SDK * Update SDK and Oculus checkouts * Update Lumin / Oculus checkout * Update SDK * Remove SimulatedHandController button mappings from BaseHandController * Update simulation input actions in shc * Hand Tracking change requests (#476) * latest changes from dev plus change requests * pulled out new interface into it's own file * updated base controller data provider profile namespace added icon for the data provider as well * updated sdk checkout * Update submodule checkouts * Refactor simulation data provider relationship * Update SDK checkout * updated simulated hand data profile with required fields for IMixedRealityHandControllerDataProvider (#480) * removed ignored meta file * Fixed merge issues * Update copyright headers * Update checkouts * Return of the global hand tracking profile * Update SDK * Fix hands not showing up issue * Simplify ISimulatedHandControllerDataProvider retrieval * Remove BaseMixedRealityHandDataProviderProfile * Remove BaseHandControllerDataProvider * Add hand settings overrides to simulation profile * bumped minor version * cleaned up base hand controller (#496) * cleaned up base hand controller * missed a few * Add docs to explaoin what OnInspectorAdditionalGUI does in simulation * Update submodules * updated oculus * Update submodule * Remove hand ray type setting * Change requests/cleanup definitions (#497) * updated simulated hand controller pose type from class to struct removed allocators each frame when lerping between two poses misc formatting * updated sdk checkout * asset organization * updated wmr checkout * updated lumin commit * Moved stopwatch utility * updated submodules * Added BaseHandDatProvider and BaseHandDataProviderProfile * Add controller pose field to base hand * Fix simulation * Fix naming * Fix UWP running in editor when not configured to * Update submodules * moved constructor and changed access modifier for the constructor * updated sdk checkout * moved numerics extension and updated wmr checkout * updated wmr checkout * updated wmr checkout * updated Lumin checkout * updated Lumin checkout * fixed hand data provider inspectors * Update Lumin,SDK * Update Lumin * updated sdk checkout * Fix platform checks for iOS, Android and WebGL * apply global override if different from platform setting * updated lumin SDK * updated lumin checkout * updated oculus checkout * Update submodules * updated lumin checkout * change-request/hand-tracking (#501) * Added IMixedRealityControllerDataProvider to IMixedRealityController updated all the controller constructors to take a data provider parameter * a bit more cleanup and ensured controllers we being added to the data provider active controller registry * updated wmr checkout * Fix simulated hand controller instantiation * Fix UseSourcePose fallback * Update checkouts * Update SDK checkout * Fix missing data provider parameter for Unity Joystick controller * Rename OpenVR Oculus Touch profile and inspector to avoid confusion * Update checkouts * Update WMR checkout * reverting Oculus Touch rename * Revert visualizer.UseSourcePoseData change * updated sdk checkout * Update SDK * misc formatting * fixed constructor arg exception * updated sdk checkout * fixed merge conflict * fixed documentation * updated simulated hand controller to use data provider reference * Fix pose change raised twice per update * Fix some docs in visualization profile * Update SDK submodule * updated submodules Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com> Co-authored-by: Simon (Darkside) Jackson <darkside@zenithmoon.com> Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.