This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
More thorough description of candidate's task #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpedziwiatr
reviewed
Aug 14, 2020
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # recruitment-tl-task-public | |||
|
|
|||
| ## Description | |||
| Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Try to point out all the problems with the code quality and how it conforms to clean code (and any other you can think of) principles. What changes would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc. | |||
| Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look on the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc. | |||
There was a problem hiding this comment.
"...look on the code..." -> "...look at the code..."
|
It is clear for me - let's merge it. |
pglabwr
approved these changes
Sep 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.