Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Commit

Permalink
Merge pull request #4 from Worldremit/more-thorough-description-of-ca…
Browse files Browse the repository at this point in the history
…ndidates-task

More thorough description of candidate's task
  • Loading branch information
pglabwr authored Sep 11, 2020
2 parents b3629e8 + 3984d49 commit fd4c027
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# recruitment-tl-task-public

## Description
Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Try to point out all the problems with the code quality and how it conforms to clean code (and any other you can think of) principles. What changes would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc.
Let's assume you became a leader of the young, immature team, which produces solutions of questionable quality. Below you'll find one of the projects the team is responsible for. Take a look into the repository, do the code review. Point out all the issues with the code quality and how it conforms to clean code (and any other you can think of) principles. Make sure that you look at the code from all possible angles and describe all the possible improvements. Detail all the changes that would have to be done (once again, from all the perspectives you can think of), for this code to become a production ready service (instead of command line application). You could consider resiliency to high loads, things like ddos attacks, auditing etc.

### Task to be reviewed
#### Task description
Expand All @@ -21,4 +21,4 @@ Implement a REST service which validates a credit card number from a common cred
## Review acceptance criteria
- code review has a form of GitHub pull request comments
- comments are in English
- code review was finished within a week (168 hours), counting from the moment, when link to recruitment task branch was received
- code review was finished within a week (168 hours), counting from the moment, when link to recruitment task branch was received

0 comments on commit fd4c027

Please sign in to comment.