CPLAT-15063 Conditionally unconvert style and children props

[greglittlefield-wf]

Motivation

Sometimes, Dart code can read props that originate from JS code (e.g., a JS component rendering/cloning a Dart component), and in cases where the JS prop value doesn't match the typings on the OverReact prop getter, you get a runtime type error.

Two common cases of this are the style and children props.

style props set by JS code are JS objects, which can't be casted to Dart Maps in the DomPropsMixin.style and UbiquitousDomPropsMixin.style getters.

children props are always Lists for Dart components rendered by Dart code, but can be nullish or a singular value when rendered by JS components, and can cause cast errors in the typed children prop getter.

Changes

• Normalize the value of the children prop getter (ReactPropsMixin.children, mixed into UiProps) to always be a List
• Normalize the value of the style prop getters (UbiquitousDomPropsMixin.style, mixed into UiProps, and DomPropsMixin.style) to convert JS object values to Dart Maps
• Add tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • All existing tests pass
    • Consumer tests pass (link to Rosie Evaluation, which is hidden on OSS repos)
    • JS component test cases in RMUI branch pass
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Client Platform member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[greglittlefield-wf]

I inlined this implementation into the getter, as opposed to making it a utility function, so that I could do props.containsKey('children') below

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[aaronlademann-wf]

This looks great! Awesome test coverage!

[aaronlademann-wf]

-1

• w_table consumer test failures appear related to these changes

[aaronlademann-wf]

+1

w_table consumer test failures were a red herring

+10

• Dart 2.7.2 / Stable CI builds and tests passed
• consumer tests with the exception of a few known flaky tests passed

@Workiva/release-management-pp

[rmconsole-wf]

+1 from RM