-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-7 Move over uiJsComponent + tests #743
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Co-authored-by: brianphillips-wk <brianphillips-wk@users.noreply.github.com>
I noted some weird test failures ultimately caused by WeakMap not initializing properly, causing issues where `_dartRefForJsRef` is used:
Digging in... Edit: fixed in 4329621 |
Also, cleanup: don't use `factory`, which doesn't seem to make a difference but isn't what the docs say to use when instantiating non-anonymous objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing around the use of style
in tests (and some #nits, but don't forget that addressing those is optional), otherwise this looks good to go!
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
All set for a final look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
We want to expose uiJsComponent and an assortment of utilities so that other teams can easily wrap JS components.
Changes
Copy uiJsComponent and prop conversion utils to over_react
Copy tests to over_react
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: