Merge Dart 2.9 boilerplate wip

[joebingham-wk]

Motivation

Dart 2.9 removed support for ignoring error-severity analyzer errors. This is already an issue, as the library currently relies on those ignore comments for undefined identifiers. Into this future, this issue will be exasperated by the enforcement of implicit cast errors that will be enforced when NNBD is introduced in Dart 2.12.

For more context, see this issue.

Changes

Introducing castUiFactory!

The main change is that a new utility, castUiFactory, was introduced. This utility works by using generics to infer the typing from the surrounding context. This utility works around the implicit cast issue by inferring the typing from the surround context.

For a reference of all permutations of the boilerplate with this utility, see the over_react examples.

Private Generated Factory Configs

The solution to the undefined_identifier errors is that identifiers prefixed with _$ will be dynamic in the future.

Component factory declarations already followed this convention, but functional component's generated UiFactoryConfigs did not. Therefore, the public config is still generated, but is deprecated. Instead, use the private config. For example:

import 'package:over_react/over_react.dart';

part 'function_component.over_react.g.dart';

UiFactory<FunctionComponentProps> FunctionComponent = uiFunction(
  (props) {
    return Dom.div()('This is a post-Dart 2.9.0 function component.');
  },
-  $FunctionComponentConfig, // ignore: undefined_identifier
+  _$FunctionComponentConfig, // ignore: undefined_identifier
);

mixin FunctionComponentProps on UiProps {}

Migrating

To migrate, you should first ensure you have migrated to the mixin-based syntax.

From there, you can run an over_react_codemod script to perform the migration!

pub global activate over_react_codemod ^1.12.0
pub global run over_react_codemod:dart2_9_upgrade

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[aaronlademann-wf]

+1

[sydneyjodon-wk]

+1

[joebingham-wk]

QA +1

• All over_react subpackages build (including over_react itself)
• Smoke tested all over_react apps / examples
• Consumer test built

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM