Merge pull request #679 from Workiva/dart-2.9-boilerplate-wip

Merge Dart 2.9 boilerplate wip

.github/workflows/dart_ci.yml

@@ -38,8 +38,15 @@ jobs:
         if: always() && ${{ matrix.sdk }} == '2.7.2' && steps.install.outcome == 'success'
 
       # Analyze before generated files are created to verify that component boilerplate analysis is "clean" without the need for building
-      - name: Analyze project source (pre-build)
-        run: pub run dart_dev analyze
+      - name: Analyze example source (pre-build)
+        run: |
+          # Analyze lib to ensure public APIs don't depend on build-to-cache files, 
+          # which could cause analysis issues for consumers who haven't run a build yet.
+          dartanalyzer lib
+          cd example/boilerplate_versions
+          if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; fi
+          if [ ${{ matrix.sdk }} = 'stable' ]; then echo 'Skip pre-build analysis for Dart versions >=2.9 and <2.12 because there will be analysis errors.'; fi
+          if [ ${{ matrix.sdk }} = 'dev' ]; then cd mixin_based/dart_2_9_compatible && dart analyze; fi
         if: always() && steps.install.outcome == 'success'
 
       - id: build
@@ -51,7 +58,7 @@ jobs:
 
       # Analyze again after generated files are created to verify that those generated classes don't cause analysis errors
       - name: Analyze project source (post-build)
-        run: pub run dart_dev analyze
+        run: if [ ${{ matrix.sdk }} = '2.7.2' ]; then pub global activate tuneup && tuneup check; else dart analyze; fi
         if: always() && steps.install.outcome == 'success' && steps.build.outcome == 'success'
 
       - name: Run tests (VM)

README.md

@@ -183,12 +183,13 @@ __`UiFactory` is a function__ that returns a new instance of a
 [`UiComponent2`](#uicomponent2)’s [`UiProps`](#uiprops) class.
 
 ```dart
-UiFactory<FooProps> Foo = _$Foo;
+UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 ```
 
 * This factory is __the entry-point__ to consuming any OverReact component.
 * The `UiProps` instance it returns can be used [as a component builder](#uiprops-as-a-builder),
 or [as a typed view into an existing props map](#uiprops-as-a-map).
+* `castUiFactory` is necessary to prevent implicit cast analysis warnings before code generation has been run.
 
 &nbsp;
 
@@ -214,7 +215,7 @@ mixin FooProps on UiProps {
 __To compose props mixin classes__, create a class alias that uses `UiProps` as the base and mix in multiple props mixins. The generated props implementation will then use it as the base class and implement the generated version of those props mixins.
 
 ```dart
-UiFactory<FooProps> Foo = _$Foo;
+UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 
 mixin FooPropsMixin on UiProps {
   String bar;
@@ -239,7 +240,7 @@ The use-case for composing multiple props mixins into a single component props c
 #### UiProps as a Map
 
 ```dart
-UiFactory<FooProps> Foo = _$Foo;
+UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 
 mixin FooProps on UiProps {
   String color;
@@ -274,7 +275,7 @@ void baz() {
 #### UiProps as a builder
 
 ```dart
-UiFactory<FooProps> Foo = _$Foo;
+UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 
 mixin FooProps on UiProps {
   String color;
@@ -353,7 +354,7 @@ They are instances of `UiProps` and `UiState`, __which means you don’t need St
 * `typedPropsFactory()` and `typedStateFactory()` are also exposed to conveniently create typed `props` / `state` objects out of any provided backing map.
 
 ```dart
-UiFactory<FooProps> Foo = _$Foo;
+UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 
 mixin FooProps on UiProps {
   String color;
@@ -741,7 +742,7 @@ that you get for free from OverReact, you're ready to start building your own cu
     import 'package:over_react/over_react.dart';
     part 'foo_component.over_react.g.dart';
 
-    UiFactory<FooProps> Foo = _$Foo; // ignore: undefined_identifier
+    UiFactory<FooProps> Foo = castUiFactory(_$Foo); // ignore: undefined_identifier
 
     mixin FooProps on UiProps {
       // Props go here, declared as fields:
@@ -771,7 +772,7 @@ that you get for free from OverReact, you're ready to start building your own cu
     import 'package:over_react/over_react.dart';
     part 'foo_component.over_react.g.dart';
 
-    UiFactory<BarProps> Bar = _$Bar; // ignore: undefined_identifier
+    UiFactory<BarProps> Bar = castUiFactory(_$Bar); // ignore: undefined_identifier
 
     mixin BarProps on UiProps {
       // Props go here, declared as fields:
@@ -826,7 +827,7 @@ that you get for free from OverReact, you're ready to start building your own cu
       );
     },
     // The generated props config will match the factory name.
-    $FooConfig, // ignore: undefined_identifier
+    _$FooConfig, // ignore: undefined_identifier
   );
 
   mixin FooProps on UiProps {
@@ -855,13 +856,13 @@ another component.
     /// * Similar to [SplitButton].
     ///
     /// See: <https://link-to-any-relevant-documentation>.
-    UiFactory<DropdownButtonProps> DropdownButton = _$DropdownButton; // ignore: undefined_identifier
+    UiFactory<DropdownButtonProps> DropdownButton = castUiFactory(_$DropdownButton); // ignore: undefined_identifier
     ```
 
   _Bad:_
     ```dart
     /// Component Factory for a dropdown button component.
-    UiFactory<DropdownButtonProps> DropdownButton = _$DropdownButton; // ignore: undefined_identifier
+    UiFactory<DropdownButtonProps> DropdownButton = castUiFactory(_$DropdownButton); // ignore: undefined_identifier
     ```
 
 &nbsp;

analysis_options.yaml

@@ -1,16 +1,20 @@
 include: package:pedantic/analysis_options.1.8.0.yaml
 
 analyzer:
+  strong-mode:
+    implicit-casts: false
   exclude:
     - _site/**
     - test_fixtures/**
     - app/**
     - tools/analyzer_plugin/**
+    - ddc_precompiled/**
   errors:
     unused_import: warning
     duplicate_import: warning
     missing_required_param: error
     must_call_super: error
+    uri_has_not_been_generated: ignore
 linter:
   rules:
     # -------------------

app/over_react_redux/todo_client/lib/src/components/app.dart

@@ -27,7 +27,7 @@ UiFactory<TodoAppProps> TodoApp = connect<AppState, TodoAppProps>(
       );
     },
     forwardRef: true,
-)(_$TodoApp); // ignore: undefined_identifier
+)(castUiFactory(_$TodoApp)); // ignore: undefined_identifier
 
 mixin TodoAppPropsMixin on UiProps {
   Function(String description) createTodo;

app/over_react_redux/todo_client/lib/src/components/app_bar/app_bar.dart

@@ -6,7 +6,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'app_bar.over_react.g.dart';
 
 UiFactory<TodoAppBarProps> TodoAppBar =
-    _$TodoAppBar; // ignore: undefined_identifier
+    castUiFactory(_$TodoAppBar); // ignore: undefined_identifier
 
 mixin TodoAppBarProps on UiProps {}
 

app/over_react_redux/todo_client/lib/src/components/app_bar/app_bar_local_storage_menu.dart

@@ -20,7 +20,7 @@ UiFactory<AppBarLocalStorageMenuProps> AppBarLocalStorageMenu = connect<AppState
         ..currentDataHasBeenModified = json.encode(localTodoAppStorage[state.name]) != json.encode(state.toJson())
       );
     },
-)(_$AppBarLocalStorageMenu); // ignore: undefined_identifier
+)(castUiFactory(_$AppBarLocalStorageMenu)); // ignore: undefined_identifier
 
 mixin AppBarLocalStorageMenuPropsMixin on UiProps {
   String currentDataSetName;

app/over_react_redux/todo_client/lib/src/components/app_bar/local_storage_menu_item_input.dart

@@ -8,7 +8,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'local_storage_menu_item_input.over_react.g.dart';
 
 UiFactory<LocalStorageMenuItemInputProps> LocalStorageMenuItemInput =
-    _$LocalStorageMenuItemInput; // ignore: undefined_identifier
+    castUiFactory(_$LocalStorageMenuItemInput); // ignore: undefined_identifier
 
 @Props(keyNamespace: '')
 mixin LocalStorageMenuItemInputProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/app_bar/save_as_menu_item.dart

@@ -6,7 +6,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'save_as_menu_item.over_react.g.dart';
 
 UiFactory<SaveAsMenuItemProps> SaveAsMenuItem =
-    _$SaveAsMenuItem; // ignore: undefined_identifier
+    castUiFactory(_$SaveAsMenuItem); // ignore: undefined_identifier
 
 mixin SaveAsMenuItemProps on UiProps {
   String initialValue;

app/over_react_redux/todo_client/lib/src/components/app_bar/saved_data_menu_item.dart

@@ -11,7 +11,7 @@ import 'package:todo_client/src/components/shared/menu_overlay.dart';
 part 'saved_data_menu_item.over_react.g.dart';
 
 UiFactory<SavedDataMenuItemProps> SavedDataMenuItem =
-    _$SavedDataMenuItem; // ignore: undefined_identifier
+    castUiFactory(_$SavedDataMenuItem); // ignore: undefined_identifier
 
 @Props(keyNamespace: '')
 mixin SavedDataMenuItemProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/create_input.dart

@@ -8,7 +8,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'create_input.over_react.g.dart';
 
 UiFactory<CreateInputProps> CreateInput =
-    _$CreateInput; // ignore: undefined_identifier
+    castUiFactory(_$CreateInput); // ignore: undefined_identifier
 
 @Props(keyNamespace: '') // No namespace so prop forwarding works when passing to the JS TextField component.
 mixin CreateInputProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/shared/avatar_with_colors.dart

@@ -9,7 +9,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'avatar_with_colors.over_react.g.dart';
 
 UiFactory<AvatarWithColorsProps> AvatarWithColors =
-        _$AvatarWithColors; // ignore: undefined_identifier
+        castUiFactory(_$AvatarWithColors); // ignore: undefined_identifier
 
 mixin AvatarWithColorsProps on UiProps {
   String fullName;

app/over_react_redux/todo_client/lib/src/components/shared/display_list.dart

@@ -7,7 +7,7 @@ import 'package:todo_client/src/components/shared/empty_view.dart';
 part 'display_list.over_react.g.dart';
 
 UiFactory<DisplayListProps> DisplayList =
-        _$DisplayList; // ignore: undefined_identifier
+        castUiFactory(_$DisplayList); // ignore: undefined_identifier
 
 @Props(keyNamespace: '') // No namespace so prop forwarding works when passing to the JS TextField component.
 mixin DisplayListProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/shared/empty_view.dart

@@ -8,7 +8,7 @@ part 'empty_view.over_react.g.dart';
 /// or an empty view such as a 404 error page.
 
 UiFactory<EmptyViewProps> EmptyView =
-        _$EmptyView; // ignore: undefined_identifier
+        castUiFactory(_$EmptyView); // ignore: undefined_identifier
 
 mixin EmptyViewProps on UiProps {
   /// The layout of the [EmptyView].

app/over_react_redux/todo_client/lib/src/components/shared/list_item_expansion_panel_summary.dart

@@ -8,7 +8,7 @@ import 'package:todo_client/src/components/shared/material_ui.dart';
 part 'list_item_expansion_panel_summary.over_react.g.dart';
 
 UiFactory<ListItemAccordionSummaryProps> ListItemAccordionSummary =
-    _$ListItemAccordionSummary; // ignore: undefined_identifier
+    castUiFactory(_$ListItemAccordionSummary); // ignore: undefined_identifier
 
 mixin ListItemAccordionSummaryProps on UiProps {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/shared/menu_overlay.dart

@@ -10,7 +10,7 @@ part 'menu_overlay.over_react.g.dart';
 /// or an empty view such as a 404 error page.
 
 UiFactory<MenuOverlayProps> MenuOverlay =
-    _$MenuOverlay; // ignore: undefined_identifier
+    castUiFactory(_$MenuOverlay); // ignore: undefined_identifier
 
 @Props(keyNamespace: '')
 mixin MenuOverlayProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/shared/todo_item_text_field.dart

@@ -10,7 +10,7 @@ part 'todo_item_text_field.over_react.g.dart';
 /// or an empty view such as a 404 error page.
 
 UiFactory<TodoItemTextFieldProps> TodoItemTextField =
-    _$TodoItemTextField; // ignore: undefined_identifier
+    castUiFactory(_$TodoItemTextField); // ignore: undefined_identifier
 
 @Props(keyNamespace: '') // No namespace so prop forwarding works when passing to the JS TextField / InputBase components.
 mixin TodoItemTextFieldProps on UiProps {

app/over_react_redux/todo_client/lib/src/components/task_count.dart

@@ -19,7 +19,7 @@ UiFactory<TaskCountBadgeProps> TaskCountBadge = connect<AppState, TaskCountBadge
     areStatePropsEqual: (nextProps, prevProps) {
       return ListEquality().equals(nextProps.assignedTodoIds, prevProps.assignedTodoIds);
     },
-)(_$TaskCountBadge); // ignore: undefined_identifier
+)(castUiFactory(_$TaskCountBadge)); // ignore: undefined_identifier
 
 mixin TaskCountBadgePropsMixin on UiProps {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/todo_list.dart

@@ -17,7 +17,7 @@ UiFactory<TodoListProps> TodoList = connect<AppState, TodoListProps>(
       );
     },
     forwardRef: true,
-)(_$TodoList); // ignore: undefined_identifier
+)(castUiFactory(_$TodoList)); // ignore: undefined_identifier
 
 mixin TodoListPropsMixin on UiProps {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/todo_list_item.dart

@@ -38,7 +38,7 @@ UiFactory<TodoListItemProps> TodoListItem = connect<AppState, TodoListItemProps>
       ..isHighlighted = isHighlighted
     );
   },
-)(_$TodoListItem); // ignore: undefined_identifier
+)(castUiFactory(_$TodoListItem)); // ignore: undefined_identifier
 
 mixin TodoListItemPropsMixin on UiProps, ListItemPropsMixin {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/user_list.dart

@@ -17,7 +17,7 @@ UiFactory<UserListProps> UserList = connect<AppState, UserListProps>(
       );
     },
     forwardRef: true,
-)(_$UserList); // ignore: undefined_identifier
+)(castUiFactory(_$UserList)); // ignore: undefined_identifier
 
 mixin UserListPropsMixin on UiProps {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/user_list_item.dart

@@ -39,7 +39,7 @@ UiFactory<UserListItemProps> UserListItem = connect<AppState, UserListItemProps>
       ..isHighlighted = isHighlighted
     );
   },
-)(_$UserListItem); // ignore: undefined_identifier
+)(castUiFactory(_$UserListItem)); // ignore: undefined_identifier
 
 mixin UserListItemPropsMixin on UiProps, ListItemPropsMixin {
   @requiredProp

app/over_react_redux/todo_client/lib/src/components/user_selector.dart

@@ -24,7 +24,7 @@ UiFactory<UserSelectorProps> UserSelector = connect<AppState, UserSelectorProps>
       );
     },
     forwardRef: true
-)(_$UserSelector); // ignore: undefined_identifier
+)(castUiFactory(_$UserSelector)); // ignore: undefined_identifier
 
 mixin UserSelectorProps on UiProps {
   String selectedUserId;

app/over_react_redux/todo_client/lib/src/components/user_selector_trigger.dart

@@ -1,7 +1,7 @@
 part of todo_client.src.components.user_selector;
 
 UiFactory<UserSelectorTriggerProps> UserSelectorTrigger =
-    _$UserSelectorTrigger; // ignore: undefined_identifier
+    castUiFactory(_$UserSelectorTrigger); // ignore: undefined_identifier
 
 @Props(keyNamespace: '')
 mixin UserSelectorTriggerProps on UiProps {

app/over_react_redux/todo_client/pubspec.yaml

@@ -32,8 +32,3 @@ dev_dependencies:
 dependency_overrides:
   over_react:
     path: '../../../'
-  react:
-    git:
-      url: https://github.com/cleandart/react-dart.git
-      ref: 6.0.0-wip
-

build.yaml

@@ -20,14 +20,36 @@ targets:
       over_react|_over_react_local_builder:
         enabled: true
         generate_for:
+          include:
+            - "lib/**"
+            - "test/**"
+            - "web/component1/**"
+            # The Dart 2 only boilerplate does not analyze cleanly without a build so the generated files need to be
+            # checked in.
+            - "example/boilerplate_versions/dart2_only/**"
           exclude:
+            # These tests analyze cleanly without a build so the generated files do not need to be checked in.
+            - "test/over_react/component_declaration/builder_integration_tests/backwards_compatible/**"
+            - "test/over_react/component_declaration/builder_integration_tests/new_boilerplate/**"
             # These test un-built base class behavior, and contain code that might look like declarations
             # and should definitely not be built
             - "test/over_react/component_declaration/builder_helpers_test.dart"
             - "test/over_react/component_declaration/component_base_test.dart"
 
       over_react|overReactBuilder:
-        enabled: false
+        enabled: true
+        generate_for:
+          include:
+            - "web/**"
+            - "example/**"
+            # These tests analyze cleanly without a build so the generated files do not need to be checked in.
+            - "test/over_react/component_declaration/builder_integration_tests/backwards_compatible/**"
+            - "test/over_react/component_declaration/builder_integration_tests/new_boilerplate/**"
+          exclude:
+            - "web/component1/**"
+            # The Dart 2 only boilerplate does not analyze cleanly without a build so the generated files need to be
+            # checked in.
+            - "example/boilerplate_versions/dart2_only/**"
 
       built_value_generator|built_value:
         generate_for:
@@ -39,10 +61,10 @@ targets:
           include:
             - test/over_react/component_declaration/redux_component_test/test_reducer.dart
 
-      build_vm_compilers|entrypoint:
-        generate_for:
-          include:
-            - "test/vm_tests/**"
+#      build_vm_compilers|entrypoint:
+#        generate_for:
+#          include:
+#            - "test/vm_tests/**"
 
       # builder uses mirrors and will cause a build to fail when using build web compilers
       # vm tests require the use of mirrors