-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-6464 Improve error message for props/state variables with initializers #318
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
@@ -400,8 +403,8 @@ class ImplGenerator { | |||
keyConstants[keyConstantName] = keyValue; | |||
constants[constantName] = constantValue; | |||
|
|||
final type = field.fields.type?.toSource(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was renamed so I could use the type
argument above without it being shadowed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you answered my feedback before i could leave it... damn you
QA +1 |
@Workiva/release-management-pp |
Motivation
This error message could be better, and indicate how to initialize these values.
Changes
In error message, add note on where to initialize values
Release Notes
Improve error message for props/state variables with initializers
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: