Merge pull request #318 from Workiva/greglittlefield-wf-patch-2

CPLAT-6464 Improve error message for props/state variables with initializers
Workiva · Jul 15, 2019 · 0167d92 · 0167d92
2 parents 327f177 + 512538b
commit 0167d92
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/src/builder/generation/impl_generation.dart b/lib/src/builder/generation/impl_generation.dart
@@ -330,7 +330,10 @@ class ImplGenerator {
           field.fields.variables.forEach((VariableDeclaration variable) {
             if (variable.initializer != null) {
               logger.severe(messageWithSpan(
-                  'Fields are stubs for generated setters/getters and should not have initializers.',
+                  'Fields are stubs for generated setters/getters and should not have initializers.\n'
+                      'Instead, initialize ${type.isProps 
+                          ? 'prop values within getDefaultProps()' 
+                          : 'state values within getInitialState()'}.',
                   span: getSpan(sourceFile, variable))
               );
             }
@@ -400,8 +403,8 @@ class ImplGenerator {
             keyConstants[keyConstantName] = keyValue;
             constants[constantName] = constantValue;
 
-            final type = field.fields.type?.toSource();
-            final typeString = type == null ? '' : '$type ';
+            final typeSource = field.fields.type?.toSource();
+            final typeString = typeSource == null ? '' : '$typeSource ';
             final metadataSrc = new StringBuffer();
             for (final annotation in field.metadata) {
               metadataSrc.writeln('  ${annotation.toSource()}');