Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4110 Add Dart 2 only IDE snippets #254

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

smaifullerton-wk
Copy link
Contributor

@smaifullerton-wk smaifullerton-wk commented Feb 28, 2019

Ultimate problem:

Currently we only provide Dart 1/2 compatible code snippets for IDEs. We'd also like to provide Dart 2-only snippets.

How it was fixed:

Added them for WebStorm (XML) and VS Code (JSON).

Testing suggestions:

  • Add snippets to IDE and make sure they work. For Webstorm, you can copy the contents of the XML file added in this PR and follow the README instructions starting at Set up CI and coverage #2 to add them.

Potential areas of regression:

None


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@seanburke-wf
Copy link

QA +1

Pulled snippets into WebStorm and verified that they work as intended.

@seanburke-wf
Copy link

@Workiva/release-management-p for merge into master

@rmconsole4-wk rmconsole4-wk merged commit d809fc4 into master Mar 1, 2019
@rmconsole4-wk rmconsole4-wk deleted the cplat-4110-dart2-only-snippets branch March 1, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants