Set up CI and coverage #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
|
I have nothing to display, for a full report click here |
| <script type="application/dart" src="over_react_test.dart"></script> | ||
| </head> | ||
| <body></body> | ||
| </html> |
There was a problem hiding this comment.
Please remove temp file
Also add .analysis_options with lints and excludes.
|
+1 |
|
Wanna just keep this open until it's public, and then make sure it runs properly before merging? |
|
Yeah that sounds good to me |
|
+1 |
Merged
|
Closing because old fork is gone. See #3 |
1 task
greglittlefield-wf
added a commit
that referenced
this pull request
Jun 19, 2020
Add warning for having a lone child setting the key prop
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need CI and coverage turned on. Also we should add an
.analysis_optionsfile.Travis and codecov will still need to be turned on once we make this repo public. But all the code will be in place once we do that.