added logic for article for classnames #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just adds logic that I think will work to correctly use "an" in front of "Armorer" and "Alchemist" in the recipe note window
|
Good starting point; thanks for getting this to my attention :) I'll reimplement this slightly differently though (mostly to support language other than English, and to not have magic constants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds logic that I think will work to correctly use "an" in front of "Armorer" and "Alchemist" in the recipe note window. I'll be honest, I'm not a programmer and I haven't tested this but I think it should be something along these lines. Just a tiny thing!