Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The autosave and revision endpoints for templates and template parts incorrectly process file-based templates #7272

Closed
wants to merge 31 commits into from
Closed

The autosave and revision endpoints for templates and template parts incorrectly process file-based templates #7272

wants to merge 31 commits into from
+973 −141

Conversation

anton-vlasenko
Copy link

@anton-vlasenko anton-vlasenko commented Aug 29, 2024 •
edited
Loading

Trac ticket: https://core.trac.wordpress.org/ticket/61970

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@anton-vlasenko anton-vlasenko mentioned this pull request Aug 29, 2024
Closed
@github-actions GitHub Actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@anton-vlasenko anton-vlasenko marked this pull request as ready for review September 2, 2024 16:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props antonvlasenko, swissspidy, spacedmonkey, kadamwhite.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@anton-vlasenko anton-vlasenko force-pushed the fix/template-parts-autosaves-dont-work branch from e73d95c to a985e54 Compare September 24, 2024 16:35
spacedmonkey
spacedmonkey reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so for. Needs testing.

@anton-vlasenko
Implement get_itemst() for template-parts.
6c5a3d6
@anton-vlasenko
Create the wp_template_part type test post.
3f24214
@anton-vlasenko
Add tests for template_parts.
6287033 
Assert response code.
@anton-vlasenko
Update the "create" tests.
6c2599f
@anton-vlasenko
Add tests for wp_template_part.
ab8198e
@anton-vlasenko
Fix @Covers tags.
b7168f8
@anton-vlasenko
Fix test_get_items_with_data method.
2eaf40e
@anton-vlasenko
Use 2 slashes for backward-compatibility reasons.
a3cec73
@anton-vlasenko
Return bad request response code when a template is file-based.
5b5a29a
@anton-vlasenko
Use constants.
7b2b187
@anton-vlasenko
Implement more tests.
aabcb59 
# Conflicts:
#	tests/phpunit/tests/rest-api/wpRestTemplateRevisionsController.php
@anton-vlasenko
Add more unit tests.
53797d1
@anton-vlasenko
Better test method names.
693c8fb
@anton-vlasenko
Remove empty lines.
b99aad5
@anton-vlasenko
Add more tests.
5a3b874
@anton-vlasenko
Add more tests.
d412db8
@anton-vlasenko
Add template parts to the revisions test class.
14a70b6
@anton-vlasenko
Add more tests.
5f9d91b
@anton-vlasenko
Implement more tests.
35da6c5
@anton-vlasenko
Implement more tests.
2d7e12f
@anton-vlasenko anton-vlasenko force-pushed the fix/template-parts-autosaves-dont-work branch from a985e54 to b9f2952 Compare October 14, 2024 18:28
@anton-vlasenko
Copy link
Author

This is looking good so for. Needs testing.

Thank you for the review, @spacedmonkey.
I’ve added testing instructions and fixed the failing PHPUnit tests.

@anton-vlasenko @spacedmonkey
Move the cast operator inside the ternary expression for better reada…
9af6348 
…bility.

Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
@Mamaduka Mamaduka mentioned this pull request Nov 13, 2024
Closed
This was referenced Jan 15, 2025
Closed
Merged
@swissspidy
Copy link
Member

Committed in https://core.trac.wordpress.org/changeset/59605

@swissspidy swissspidy closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadamwhite kadamwhite kadamwhite approved these changes

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-vlasenko @swissspidy @spacedmonkey @kadamwhite