Editor: Disable autosaving for Template Parts #64733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Are we tracking this somewhere so we don‘t forget? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I'll create a separate issue. Did we ship the corresponding PHP code in core? I think autosaves and both post types will support revisions at some point in the future. |
|
Unless I misread the core PR/ticket, the changes in WP 6.6 only covered Font-related post types. Templates and Template Parts will need special handling, as both declare support for See: |
|
Well, then need to explicitly call |
|
@swissspidy, what would be the best place to handle this in Core? Should we remove support directly in |
|
In |
8316329 to
f67a1a7
Compare
|
This is ready for final review. Related:
|
|
@Mamaduka If the only reason to disable autosaving is this warning message, I propose waiting until the core fix is merged rather than disabling autosaving (fixing these endpoints shouldn't take long). I'm working on the fix. This bug wasn't discovered earlier because unit tests didn't catch it. The unit tests were written for templates but not for template parts, as it was assumed they would behave similarly :(. |
|
@anton-vlasenko, I thought autosaves never worked for these post types because of hardcoded values in the store. Of course, fixing the original bug is more preferred than disabling the autosaves feature. |
|
So should we work towards enabling autosaves then rather than disabling? :) |
|
@swissspidy, you said it better :) |
|
Closing in favor of WordPress/wordpress-develop#7272. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR disables autosaving for the Template Parts entity. Hardcoding this logic shouldn't be necessary after the minimum required version is bumped to WP 6.6. See #61622 (comment).
Why?
Currently, autosaving isn't supported for Templates and Template parts. Related actions cause failed requests or PHP warnings.
Testing Instructions
debug.log.Testing Instructions for Keyboard
Same.
Screenshots or screencast