Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky navigation-frontend-interactivity e2e tests #68667

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 15, 2025

Alternatives to #68643

What?

Trying to solve the flaky tests in navigation-frontend-interactivity.spec.js:

How?

As mentioned in this comment, this may be because the canvas loader disappears very early. As a fallback, wait for the editor canvas instead of the canvas loader.

Testing Instructions

Let's see if the E2E tests are stable and successful.

@t-hamano t-hamano self-assigned this Jan 15, 2025
@t-hamano t-hamano added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Flaky tests detected in 7419d61.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12780055700
📝 Reported issues:

@Mamaduka Mamaduka self-requested a review January 15, 2025 04:28
@t-hamano t-hamano changed the title DO NOT MEREGE: Fix flaky navigation-frontend-interactivity e2e tests Fix flaky navigation-frontend-interactivity e2e tests Jan 15, 2025
@t-hamano t-hamano marked this pull request as ready for review January 15, 2025 05:17
@t-hamano t-hamano requested a review from kevin940726 as a code owner January 15, 2025 05:17
Copy link

github-actions bot commented Jan 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @t-hamano!

Let's give it a try. There are no failures in five runs.

@Mamaduka Mamaduka merged commit 4085555 into trunk Jan 15, 2025
72 checks passed
@Mamaduka Mamaduka deleted the try/e2e-fix-nav-frontend-iapi branch January 15, 2025 09:36
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants