Skip flaky 'navigation-frontend-interactivity' e2e tests on Firefox #68643
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in d2c0199. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12754022430
|
|
Now, tests are failing on Chrome 😞 I might entirely skip these tests. |
|
@madhusudhand is this related to the visibility of |
|
@afercia, yes. This is related to I guess it's a sign to focus on the actual fix 😄 |
|
Looking at the screenshot of the failed Ci, could this be because the canvas loader disappears early on?
Would it be worth trying to restore the code that was removed here? 7e24ae4#diff-5c7b7c2d979885b0b5c1c5c056b81f665bcd8c8374053ee63e43a3731f5db388L48-L51 Discussion about this code: #61629 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These tests are consistently failing (example). Skipping them for Firefox until anyone has time to debug the root cause.
Testing Instructions
Testart E2E test CI jobs a couple of times. Confirm that skipped tests aren't failing for other browsers.