Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom Out: Prevent showing Quick Inserter in zoom out mode #68636

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Zoom Out: Prevent showing Quick Inserter in zoom out mode #68636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/block-editor/src/components/block-tools/use-show-block-tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export function useShowBlockTools() {
getBlockMode,
getSettings,
__unstableGetEditorMode,
isZoomOut,
isTyping,
} = unlock( select( blockEditorStore ) );

Expand All @@ -37,12 +38,14 @@ export function useShowBlockTools() {
hasSelectedBlock &&
isUnmodifiedDefaultBlock( block ) &&
getBlockMode( clientId ) !== 'html';
const isZoomOutMode = isZoomOut();
const _showEmptyBlockSideInserter =
clientId &&
! isTyping() &&
// Hide the block inserter on the navigation mode.
// See https://github.com/WordPress/gutenberg/pull/66636#discussion_r1824728483.
editorMode !== 'navigation' &&
! isZoomOutMode &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this is a regression, as I couldn't identify the specific commit that introduced the bug. However, I believe this is the most appropriate place to implement the change to effectively address the issue.

isEmptyDefaultBlock;
const _showBlockToolbarPopover =
! getSettings().hasFixedToolbar &&
Expand Down
Loading