-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out: Prevent showing Quick Inserter
in zoom out mode
#68636
base: trunk
Are you sure you want to change the base?
Zoom Out: Prevent showing Quick Inserter
in zoom out mode
#68636
Conversation
Quick Inserter
in zoom out modeQuick Inserter
in zoom out mode
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @Mamaduka, |
const _showEmptyBlockSideInserter = | ||
clientId && | ||
! isTyping() && | ||
// Hide the block inserter on the navigation mode. | ||
// See https://github.com/WordPress/gutenberg/pull/66636#discussion_r1824728483. | ||
editorMode !== 'navigation' && | ||
! isZoomOutMode && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure if this is a regression, as I couldn't identify the specific commit that introduced the bug. However, I believe this is the most appropriate place to implement the change to effectively address the issue.
At first glance, this proposal does not seem like the proper fix. It just hides the issue instead of fixing it. Unfortunately, I don't have any alternative suggestions since I'm less familiar with the internals of the "Zoom out mode" feature. |
Got it, Thanks for the review @Mamaduka. |
What, Why and How?
The
Quick Inserter
remained visible duringzoom out
mode due to a missing check in the rendering logic. The issue was resolved by adding a condition to verify ifzoom out
mode is active before displaying theQuick Inserter
.Testing Instructions
Site Editor
.paragraph
block.Quick Inserter
becomes visible when theparagraph
block is selected.Quick Inserter
is not visible when zoomed out.Screencast
Screen.Recording.2025-01-13.at.4.29.35.PM.mov
Closes: #68287