Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Featured Image: Adds control to clear the the overlay color. #68525

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Post Featured Image: Adds control to clear the the overlay color. #68525

merged 1 commit into from
Jan 7, 2025
+1 −0

Conversation

vipul0425
Copy link
Contributor

Fixes: #68524

What?

  • Adds a clear option to clear the overlay color of the featured image block.

Testing Instructions

  1. Add Featured Image Block.
  2. Set a featured image.
  3. Click on the 'Overlay Color' dropdown under 'Settings/Style' > 'Color' > 'Overlay
  4. Observe that the 'Clear' button.

Screenshots or screencast

Before After
image image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Post Featured Image Affects the Post Featured Image Block labels Jan 7, 2025
@Mamaduka Mamaduka changed the title Post-featured-image: Adds control to clear the the overlay color. Post Featured Image: Adds control to clear the the overlay color. Jan 7, 2025
Mamaduka
Mamaduka approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @vipul0425!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 7, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 7, 2025
@ruchirgoswami ruchirgoswami mentioned this pull request Jan 7, 2025
Closed
6 tasks
@Mamaduka Mamaduka enabled auto-merge (squash) January 7, 2025 11:42
@Mamaduka Mamaduka merged commit 25cf31f into WordPress:trunk Jan 7, 2025
71 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 7, 2025
westonruter added a commit that referenced this pull request Jan 7, 2025
@westonruter
Merge branch 'trunk' of https://github.com/WordPress/gutenberg into t…
88d679c 
…ry/interactivity-lazy-hydration

* 'trunk' of https://github.com/WordPress/gutenberg: (143 commits)
  Update: Bundle upload media. (#68522)
  Add: Media field changing ui to Dataviews and content preview field to posts and pages (#67278)
  Bump the react-native group with 2 updates (#68095)
  Check Storybook build on CI for PRs (#68466)
  Bump the github-actions group across 1 directory with 2 updates (#68436)
  Classic theme preview: remove admin-bar class name (#68519)
  Remove geriux as code owner (#68523)
  Post Featured Image: Adds control to clear the the overlay color (#68525)
  Components: Standardize reduced motion handling using media queries (#68421)
  Upgrade Playwright to v1.49 (#68504)
  Document Outline: Use block client ID as unique 'key' (#68502)
  Storybook: Add UnitControl story (#67346)
  Details: Add allowedBlocks and TemplateLock attributes (#68489)
  Post Comment Link: Show Border Control By Default (#68506)
  Query Total: Show Border Controls By Default (#68507)
  RSS: Added Colour support (#66419)
  Refactor: Separate input form styles to a dedicated stylesheet (#68501)
  Code quality: Fix typos (#67304)
  Page List: Added color support (#66430)
  Fix flaky DataViews list arraow nav e2e tests (#68503)
  ...
@t-hamano t-hamano mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 20.1
Development

Successfully merging this pull request may close these issues.

Inconsistency in Clear Overlay Color Option in featured-image block.
2 participants
@vipul0425 @Mamaduka