Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: update components provider story #32743

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Components: update components provider story #32743

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2338339
Refactor outerContext value out of story component
ciampo Jun 16, 2021
450d655
Add more descriptive text to Card contents
ciampo Jun 16, 2021
3e63540
Remove unnecessary outer fragment
ciampo Jun 16, 2021
350c6c4
Move "as=div" to innerContext
ciampo Jun 16, 2021
6603f6f
Change elevation to lower value to make it easy to visually debug
ciampo Jun 16, 2021
fae7cfa
Use `style` prop instead of `css` for applying CSS inline styles
ciampo Jun 16, 2021
37ff2f4
Add text outline via inner context
ciampo Jun 16, 2021
d3e6693
Use new `Card` component, remove debug styles
ciampo Jun 18, 2021
ebf2fef
Change innerContext background value to be different than white
ciampo Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 40 additions & 35 deletions packages/components/src/ui/context/stories/ComponentsProvider.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,39 @@ export default {
title: 'G2 Components (Experimental)/ContextSystemProvider',
};

const outerContext = {
Card: {
isRounded: false,
elevation: 15,
},
CardBody: {
as: 'a',
href: 'https://wordpress.org',
style: {
display: 'block',
},
},
};

const innerContext = {
Card: {
css: {
background: 'white',
style: {
background: 'rgba(35, 255, 55, 0.2)',
},
},
CardBody: {
as: 'div',
},
};

const InnerContent = memo( () => {
const state = useSomeContext();
const isEven = state % 2 === 0;
return (
<View css={ { background: isEven ? 'red' : 'initial' } }>
{ state }
<View style={ { background: isEven ? 'red' : 'initial' } }>
<Text>Card (inside innerContext)</Text>
<br />
<Text>Counter:{ state }</Text>
</View>
);
} );
Expand All @@ -41,7 +60,7 @@ const InnerCard = memo( () => {
return (
<View style={ { padding: 40 } }>
<Card>
<CardBody as="div" style={ { border: '3px solid green' } }>
<CardBody style={ { border: '3px solid green' } }>
<InnerContent />
</CardBody>
</Card>
Expand All @@ -53,40 +72,26 @@ export const Default = () => {
const [ state, update ] = useState( 0 );
const forceUpdate = () => update( ( prev ) => prev + 1 );

const value = {
Card: {
isRounded: false,
elevation: 100,
},
CardBody: {
as: 'a',
href: 'https://wordpress.org',
style: {
display: 'block',
},
},
};

return (
<>
<SomeContext.Provider value={ state }>
<button onClick={ forceUpdate }>Force Update</button>
<ContextSystemProvider value={ value }>
<Card>
<CardBody>
<Text optimizeReadabilityFor="blue">Card</Text>
<ContextSystemProvider value={ innerContext }>
<InnerCard />
</ContextSystemProvider>
</CardBody>
</Card>
</ContextSystemProvider>
<SomeContext.Provider value={ state }>
<button onClick={ forceUpdate }>
Force Update (increment counter)
</button>
<ContextSystemProvider value={ outerContext }>
<Card>
<CardBody>
<Text>Card</Text>
<Text>Card (inside outerContext)</Text>
<ContextSystemProvider value={ innerContext }>
<InnerCard />
</ContextSystemProvider>
</CardBody>
</Card>
</SomeContext.Provider>
</>
</ContextSystemProvider>
<Card>
<CardBody>
<Text>Card (outside of outerContext)</Text>
</CardBody>
</Card>
</SomeContext.Provider>
);
};