Components: update components provider story #32743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
Working on this refactor has exposed some unexpected behaviour from the Context system: Values from contexts leak to components outside of the context provider
On top of this, if this patch is applied, the resulting behaviour seems also unexpected: diff --git a/packages/components/src/ui/context/stories/ComponentsProvider.stories.js b/packages/components/src/ui/context/stories/ComponentsProvider.stories.js
index 75f6414129..bed36eff14 100644
--- a/packages/components/src/ui/context/stories/ComponentsProvider.stories.js
+++ b/packages/components/src/ui/context/stories/ComponentsProvider.stories.js
@@ -31,6 +31,11 @@ const outerContext = {
display: 'block',
},
},
+ Text: {
+ style: {
+ outline: '2px solid orange',
+ },
+ },
};
const innerContext = {
Incrementing the counter (force update) makes the inner card component lose the
|
11 tasks
5 tasks
c16942f to
7715f32
Compare
5705bfc to
6c2cbd9
Compare
93afcd7 to
acb8fa3
Compare
6c2cbd9 to
5bd2875
Compare
acb8fa3 to
07c3af6
Compare
|
Rebased on top of @sarayourfriend could you have a look at this? |
sarayourfriend
approved these changes
Jun 22, 2021
| const innerContext = { | ||
| Card: { | ||
| css: { | ||
| style: { | ||
| background: 'white', |
There was a problem hiding this comment.
Should this be something other than white, something we can actually see the difference of?
There was a problem hiding this comment.
Good point, I changed it to a shade of green in aff830c
9e89ed6 to
0dc81d6
Compare
0dc81d6 to
ebf2fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #32566, this PR cleans up the
ComponentsProviderstorybook storyThis PR was mainly created to highlight a bug in the g2 Context system, which was fixed by #32745.
Testing instructions
npm run storybook:devand visithttp://localhost:50240/?path=/story/g2-components-experimental-contextsystemprovider--defaultScreenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).