Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear event listeners on unmount in Tooltip component #32729

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Clear event listeners on unmount in Tooltip component #32729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/src/tooltip/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ function Tooltip( { children, position, text, shortcut } ) {
};
const clearOnUnmount = () => {
delayedSetIsOver.cancel();
document.removeEventListener( 'mouseup', cancelIsMouseDown );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting eslint warnings about us not using ownerDocument here. Maybe one for a followup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attached event is using document already, so yeah probably a followup, and not related to this PR.

};

useEffect( () => clearOnUnmount, [] );
Expand Down