Clear event listeners on unmount in Tooltip component #32729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Jun 16, 2021
| @@ -168,6 +168,7 @@ function Tooltip( { children, position, text, shortcut } ) { | |||
| }; | |||
| const clearOnUnmount = () => { | |||
| delayedSetIsOver.cancel(); | |||
| document.removeEventListener( 'mouseup', cancelIsMouseDown ); | |||
There was a problem hiding this comment.
I'm getting eslint warnings about us not using ownerDocument here. Maybe one for a followup?
There was a problem hiding this comment.
The attached event is using document already, so yeah probably a followup, and not related to this PR.
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially address #31907.
The
<Tooltip>component is not cleaning up event listeners correctly when unmounting.How has this been tested?
Follow the first part of the reproduction steps in #31907.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).