-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial plugin readme.md based on template from dd32 #281
Conversation
Remove block border on type
Prevent input for non-text selections
Use functions instead of commands where appropriate
…tyle. Also make it keyboard friendly (#136) * update the TinyMCE per Block prototype UI to match the Prototype UI style * Adding heading block * Adding a paragraph block and moving to React - preact has some state updating bugs * Allowing removing/merging components using backspace * Handling navigation using arrow keys * Adding a simple quote block
…hs, quotes, headings) (#148)
- Includes a new drag and drop mockup - Includes an admin with the sidebar closed - Includes an updated Sketch file that has the admin UI stuff
Update Mockups
Tinymce single/mimic ui prototype
Hide inline formatting toolbar along with rest of block UI
Tinymce single/mimic ui prototype
Start work on inserter
Add undo levels for moving blocks
Lighter UI: only leave align centre, clearer remove format icons
Fix caption check on deselect
Note: It creates additional paragraphs when dragging non editable blocks. This reverts commit bef6be3.
These mockup updates include general refinements and polish, per Github and Slack discussions. Notably around: - Galleries. Props @j-falk for ideas here. Trash and edit buttons when selecting individual images in a gallery, and button for advanced gallery editing, where you'd also be able to add more images to the gallery, or rearrange, in the case of a slideshow version of the gallery. - Drag and drop. Props @iseulde for the idea of showing a blue line for the dropzone. The gray area is a ghost of where you're dragging from, so the blocks don't size around when you drag. - A new approach to inserting content. It generally happens on a newline, and the plus then shows up to the left, where the up/down arrows would show up for a non-empty block. We'd then have a permanent "insert" button somewhere in the Admin UI to go with this, for when you need to insert content between two letters. See also #78. - Added empty versions of Quote and Image block. Imagine the use case of _type type type, press enter for newline, type `/ima` to open inserter searched to Image, press enter, arrow down, type type type_. In that case you'd simply inserted an image placeholder block which you could later upload to, or pick an image from the media library.
Update mockups
Filenames with unencoded spaces worked yesterday. Suddenly it doesn't. No idea why. Will use dashes instead of spaces in the future.
Fix weirdly broken markdown
Adding plugin folder for the project.
Nice, thank you! Is there any overlap with #278? |
I think #278 is only about inline documentation in index.php. But you are right that there is a plugin header in index.php which I should move over to the readme.md as part of this pull request. Will make sure to do that in the next commit. |
Sorry that this PR sort of fell off the map in the crazy whirlwind of development that's happened in the last week. Is it worth rebasing, fixing? How should we merge it? Is it something we should revisit down the road instead or can we make a new PR with the most important changes only, which seem to be the stuff near the top (contributors, versions, etc.)? |
Closing for now. We can reopen when it becomes pressing. |
Sorry, totally got swamped at work so haven't been able to do anything around this (or other things too). But I will try to follow along and become more active later if I have the chanse and there is anything that I can contribute with. Thanks for your effort! |
Oh totally understandable, and appreciate the contributions! :) |
Initiated a readme.md file with syntax that will work both on github and on wordpress.org when this plugin gets pushed to the .org repo.
Based on dd32's template from https://github.com/dd32/feature-plugin-testing/blob/master/README.md.
I thought I would get this pullrequest setup and continue working on the actual content in the coming days.