Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a quote with cite block #153

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Conversation

youknowriad
Copy link
Contributor

A quote with cite is a block composed of two "inputs", which is a good technical challenge to solve. I found that with the current API, it's flexible enough to handle the keyboard navigation between these two inputs and the other blocks.

@youknowriad youknowriad added the [Type] Enhancement A suggestion for improvement. label Mar 1, 2017
@youknowriad youknowriad self-assigned this Mar 1, 2017
@youknowriad youknowriad force-pushed the update/inline-tinymce branch from 09fcd76 to b224349 Compare March 1, 2017 10:35
@youknowriad youknowriad merged commit 1110690 into master Mar 1, 2017
@youknowriad youknowriad deleted the update/inline-tinymce branch March 1, 2017 11:17
@aduth
Copy link
Member

aduth commented Mar 1, 2017

Have you started to think how you might support inline formatting for these sorts of nested inputs? For example, adding a link to the citation or bolding text within the quote paragraphs. As textareas this seems like it'd be difficult to support.

@youknowriad
Copy link
Contributor Author

Yes Actually the quote paragraph is not a textarea, it's a restricted tinymce, so this would be possible. For the cite, I've used a textarea for now, but it's easy enough to switch to a restricted tinymce as well. I have two utility components to deal with content. A textarea and a tinymce instance, both with some possible customizations. I tried to note on this doc, the different technical aspects to consider when writing a block https://docs.google.com/document/d/1kxHO_psq-OuWzSQLCRgbfRKTdOVuf6WYsVkkFiKfJoY/edit#heading=h.edr2oork5328

nylen pushed a commit that referenced this pull request Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants