Add/block preview #26346
Add/block preview #26346
Conversation
| @@ -204,11 +204,22 @@ example: { | |||
| 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent et eros eu felis.' | |||
| ), | |||
| }, | |||
| }, | |||
| }, | |||
There was a problem hiding this comment.
should we indent the whole object here using tabs? (otherwise, we might want to keep this for a separate PR and revert this line)
| @@ -30,6 +30,8 @@ Width of the preview container in pixels. Controls at what size the blocks will | |||
|
|
|||
| `viewportWidth` can be used to simulate how blocks look on different device sizes or to make sure make sure multiple previews will be rendered with the same scale, regardless of their content. | |||
|
|
|||
| `viewportWidth` can be override in example object with the property `viewportWidth`. | |||
There was a problem hiding this comment.
BlockPreview component can be used in very different contexts, I don't think we should be mentioning the "example" object here. Can we leave this out?
There was a problem hiding this comment.
Oh sorry, I was not clear enough, I was thinking we should remove the whole sentence from here.
| ( hoveredItemBlockType.example && | ||
| hoveredItemBlockType.example | ||
| .viewportWidth ) || | ||
| 500 |
There was a problem hiding this comment.
Potentially you could have written hoveredItemBlockType.example?.viewportWidth ?? 500
|
Thanks for review. Sorry for the lack of description, it's my first PR. But I take note for the next one |
|
Congratulations on your first merged pull request, @jeff-be! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Description
closes #26289
How has this been tested?
Screenshots
Types of changes
Checklist: