Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve customize value of viewportWidth in block preview #26323

Closed
wants to merge 1 commit into from
Closed

improve customize value of viewportWidth in block preview #26323

wants to merge 1 commit into from

Conversation

jeff-be
Copy link
Contributor

@jeff-be jeff-be commented Oct 20, 2020

Description

#26289

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@jeff-be
Copy link
Contributor Author

jeff-be commented Oct 21, 2020

#26346

@youknowriad youknowriad added [Type] New API New API to be used by plugin developers or package users. [Feature] Block API API that allows to express the block paradigm. labels Oct 21, 2020
@youknowriad
Copy link
Contributor

At first sight, this API looks useful:

  • Should we update the block registration example docs to mention this property?

youknowriad
youknowriad reviewed Oct 21, 2020
View reviewed changes
packages/block-editor/src/components/block-preview/README.md
@@ -26,6 +26,8 @@ A block instance (object) or a blocks array you would like to render a preview.
* **Type:** `Int`
* **Default:** `700`

**** Modify here the documentation to have a customize value ****
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this : #26346

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we close the current PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad left review comments

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] New API New API to be used by plugin developers or package users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-be @youknowriad @mberard-smartfire