Api Fetch: Fix fetch-all preloading. #23807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +41 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
I think we should close in favor of #23823 . Thoughts @epiqueras |
|
I think adding a shortcut for |
|
Yeah, why would adding an extra parameter be better than this? |
38255af to
1962ed7
Compare
|
This doesn’t fix the issue. My pr fixes two issues. |
|
What issues? |
| '/wp/v2/taxonomies?per_page=100&context=edit', | ||
| '/wp/v2/pages?per_page=100&context=edit', | ||
| '/wp/v2/taxonomies?context=edit', | ||
| '/wp/v2/pages?context=edit', |
There was a problem hiding this comment.
Suggested change
| '/wp/v2/pages?context=edit', | |
| '/wp/v2/pages?per_page=100&context=edit', |
This should not be changed.
There was a problem hiding this comment.
Because pages is paginated, as pages requires a database call. Where taxonomies is call to registered taxonomies and is not paginated.
I will flip the question around on your @epiqueras why was it changed in the first place?
There was a problem hiding this comment.
Because we don't need 100 per page, the default is fine.
There was a problem hiding this comment.
Have we changed the pages fetch to not be a fetch all? If not, this preload won't match anymore because the fetch all middleware will force a per_page=100.
There was a problem hiding this comment.
It was never 100. It was always the default.
spacedmonkey
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23673